Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1371093002: Chromium changes required to roll breakpad GPU fingerprint changes. (Closed)

Created:
5 years, 2 months ago by Tobias Sargeant
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/breakpad/src/ to b0383cd494e736720d237d61af2912bb60960cd8. $ git log 9e9c3563a..b0383cd49 --date=short --format='%ad %ae %s' 2015-09-28 primiano Add GPU fingerprint information to breakpad microdumps. Add chromium changes required for roll. BUG=536769 Committed: https://crrev.com/03825da8ed157eb110afc3895b1d1967b1702395 Cr-Commit-Position: refs/heads/master@{#351078}

Patch Set 1 #

Patch Set 2 : Add breakpad roll. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/crash/content/app/breakpad_linux.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Tobias Sargeant
PTAL. Primiano suggested splitting the GPU fingerprint CL up, starting with the minimal change that ...
5 years, 2 months ago (2015-09-28 13:45:57 UTC) #2
Primiano Tucci (use gerrit)
LGTM let's get the roll unblocked, so we can resume the discussion on the GPU ...
5 years, 2 months ago (2015-09-28 13:56:22 UTC) #3
Primiano Tucci (use gerrit)
+mark to stamp, I think he should be online right now.
5 years, 2 months ago (2015-09-28 13:58:00 UTC) #5
Mark Mentovai
It’s true. LGTM.
5 years, 2 months ago (2015-09-28 13:59:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371093002/20001
5 years, 2 months ago (2015-09-28 14:05:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 16:11:52 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:13:19 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03825da8ed157eb110afc3895b1d1967b1702395
Cr-Commit-Position: refs/heads/master@{#351078}

Powered by Google App Engine
This is Rietveld 408576698