src/objects.h - Issue 1371083003: [presubmit] Enable readability/namespace linter checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 1371083003: [presubmit] Enable readability/namespace linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 225a7db42e0cfab92c786cea07095731304ffa22..baeab70812a2457af336913b4ca35b115df038ac 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -10624,6 +10624,8 @@ class KeyAccumulator final BASE_EMBEDDED {

int length_;

DISALLOW_COPY_AND_ASSIGN(KeyAccumulator);

};

-} } // namespace v8::internal

+} // NOLINT, false-positive due to second-order macros.

Michael Starzinger 2015/09/29 12:28:11 The linter is confused by our gigantic second-orde

#endif // V8_OBJECTS_H_

« no previous file with comments | « src/modules.h ('k') | src/objects-inl.h » ('j') | no next file with comments »