chrome/browser/resources/md_policy/policy_group.html - Issue 1371073003: Display material design policies grouped by tags.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_policy/policy_group.html

Issue 1371073003: Display material design policies grouped by tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tags as string array. Removed listOf. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_policy/md_policy.html ('K') | « chrome/browser/resources/md_policy/policy_group.css ('k') | chrome/browser/resources/md_policy/policy_group.js » ('j') | chrome/test/data/webui/policy_ui_material.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer_config.html">

	2 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

	3

	4 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-card/paper-card.h tml">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/typography .html">

	7

	8 <link rel="import" href="chrome://md-policy/strings.html">

	9

	10 <dom-module id="policy-group">

	11 <link rel="import" type="css" href="chrome://md-policy/policy_group.css">

	12 <template>

	13 <paper-card heading="[[translatedRiskTag]]"

	14 aria-label="[[translatedRiskTag]]">

	15 <div class="card-content">

	16 <div id="content">

	17 <template is="dom-repeat" items="[[policies_]]" as="policy">
	Dan Beam 2015/11/03 18:22:31 should this be an iron-list? is the size of polic should this be an iron-list? is the size of policies_ bounded in practice? fhorschig 2015/11/22 17:55:27 The iron-list usually has the advantage of renderi Show quoted text On 2015/11/03 18:22:31, Dan Beam wrote: > should this be an iron-list? is the size of policies_ bounded in practice? The iron-list usually has the advantage of rendering items when they would be visible on screen. This behavior causes trouble for me because I need (reliable and constant) access to all DOM elements that are created. The size of policies_ is not technically but conceptually bounded. A group will contain a very small subset of the chromium policies [1]. I don't think there would be a recognizable impact when switching to iron-list. [1] For further reference or if you are interested in the numbers: There are ~300 policies which only contain ~50-60 policies that may influence a user's privacy/security. Even if a group would contain nearly all of them, every single one would have to be active to be displayed. Last time I checked the list of policies, there was not a single group that contains 20 or more policies.
	18 <p>[[policy.key]]</p>

	19 </template>

	20 </div>

	21 </div>

	22 </paper-card>

	23 </template>

	24 <script src="chrome://md-policy/policy_group.js"></script>

	25 </dom-module>

OLD	NEW