chrome/browser/resources/md_policy/md_policy.html - Issue 1371073003: Display material design policies grouped by tags.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_policy/md_policy.html

Issue 1371073003: Display material design policies grouped by tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tags as string array. Removed listOf. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/md_policy/md_policy.css ('k') | chrome/browser/resources/md_policy/policy_group.css » ('j') | chrome/browser/resources/md_policy/policy_group.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>Policies</title>	5 <title>Policies</title>

	6 <link rel="import" href="chrome://md-policy/policy_ui.html">

	7 <link rel="import" type="css" href="chrome://resources/css/roboto.css">

	8 <link rel="stylesheet" type="text/css" href="chrome://md-policy/md_policy.css" >

6 </head>	9 </head>

7 <body>	10 <body>

8 <h1>A Material Design policy page is under construction!</h1>	11 <policy-ui></policy-ui>
	Dan Beam 2015/11/03 17:52:55 can you just inline <policy-ui>'s contents here? can you just inline <policy-ui>'s contents here? you're not using CSS variables in the stylesheet, so there's really no reason it has to be it's own element, AFAICT fhorschig 2015/11/22 17:55:27 What do you mean by "inline <policy-ui>'s contents Show quoted text On 2015/11/03 17:52:55, Dan Beam wrote: > can you just inline <policy-ui>'s contents here? you're not using CSS variables > in the stylesheet, so there's really no reason it has to be it's own element, > AFAICT What do you mean by "inline <policy-ui>'s contents"? The component itself is receiver of messages and generates groups from them, so I would use scripts that are not tied to an Polymer object. Is that the right way? After all, I will definitely need an object that will receive the messages and generates groups. If you mean with "inline <policy-ui>'s contents" just moving the definition of the DOM to this file, I can do this. Please correct me if I am missing the point, but I guess this would be a similar situation to Patchset 3 where this was critizised: https://codereview.chromium.org/1371073003/patch/180001/190009
9 </body>	12 </body>

10 </html>	13 </html>

OLD	NEW