chrome/browser/resources/md_policy/md_policy.html - Issue 1371073003: Display material design policies grouped by tags.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_policy/md_policy.html

Issue 1371073003: Display material design policies grouped by tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed readonly to private properties. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>Policies</title>	5 <title>Policies</title>

	6 <link rel="import" href="chrome://md-policy/policy_ui.html">

	7 <link rel="import" type="css" href="chrome://resources/css/roboto.css">

	8 <link rel="stylesheet" type="text/css" href="chrome://md-policy/md_policy.css" >

6 </head>	9 </head>

7 <body>	10 <body>

8 <h1>A Material Design policy page is under construction!</h1>	11 <policy-ui></policy-ui>
	Dan Beam 2015/10/14 21:05:06 what's the point of this element/file? you should what's the point of this element/file? you should inline contents of policy_ui.html here instead the only reason you'd need to wrap in a custom-element for this is if you do --css-variable-expansion fhorschig 2015/10/14 21:30:29 Do you mean like in Patchset #3 [1]? If I wouldn' Show quoted text On 2015/10/14 21:05:06, Dan Beam wrote: > what's the point of this element/file? you should inline contents of > policy_ui.html here instead > > the only reason you'd need to wrap in a custom-element for this is if you do > --css-variable-expansion Do you mean like in Patchset #3 [1]? If I wouldn't use a custom element, I would need something else to handle the data from chrome and fill a repeat-dom with it. Is that possible (or even more elegant) without a custom-element? [1] https://codereview.chromium.org/1371073003/patch/180001/190009
9 </body>	12 </body>

10 </html>	13 </html>

OLD	NEW