chrome/browser/resources/md_policy/cr_policy_group.html - Issue 1371073003: Display material design policies grouped by tags.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_policy/cr_policy_group.html

Issue 1371073003: Display material design policies grouped by tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleaning and Refactoring. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/md_policy/cr_policy_group.css ('k') | chrome/browser/resources/md_policy/cr_policy_group.js » ('j') | chrome/browser/resources/md_policy/cr_policy_group.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.htm l">

	5

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-card/paper-ca rd.html">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper- button.html">

	8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/typogr aphy.html">

	9 </head>

	10 <body>

	11 <dom-module id="cr-policy-group">
	stevenjb 2015/10/06 22:42:03 nit: We've been moving towards not using a cr- pre nit: We've been moving towards not using a cr- prefix for elements that are page specific and have a descriptive prefix (e.g. policy-). Also, even where we still have the cr- prefix we generally don't name the file with cr_ since it just adds noise and length. So, I would suggest policy_group.html and <policy-group> fhorschig 2015/10/07 16:37:11 Done. Show quoted text On 2015/10/06 22:42:03, stevenjb wrote: > nit: We've been moving towards not using a cr- prefix for elements that are page > specific and have a descriptive prefix (e.g. policy-). Also, even where we still > have the cr- prefix we generally don't name the file with cr_ since it just adds > noise and length. So, I would suggest policy_group.html and <policy-group> Done.
	12 <link rel="import" type="css" href="chrome://md-policy/cr_policy_group.css ">

	13 <template>

	14 <paper-card heading="[[riskTag]]"

	15 aria-label="[[riskTag]]">
	stevenjb 2015/10/06 22:42:03 Use one line when everything fits. When it doesn't Use one line when everything fits. When it doesn't, event the following line 4 spaces. See https://www.chromium.org/developers/web-development-style-guide#Body fhorschig 2015/10/07 16:37:11 Done. Show quoted text On 2015/10/06 22:42:03, stevenjb wrote: > Use one line when everything fits. > When it doesn't, event the following line 4 spaces. > See https://www.chromium.org/developers/web-development-style-guide#Body Done.
	16 <div id="content"

	17 class="card-content"></div>

	18 <div class="card-actions">

	19 <paper-button>Unfold all</paper-button>

	20 </div>

	21 </paper-card>

	22 </template>

	23 <script src="chrome://md-policy/cr_policy_group.js"></script>

	24 </dom-module>

	25 </body>

	26 </html>

	27

OLD	NEW