Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1371073002: add missing content_test_mojo_bindings gyp dep in content_tests.gypi (Closed)

Created:
5 years, 2 months ago by Mostyn Bramley-Moore
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, tsniatowski
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add missing content_test_mojo_bindings gyp dep in content_tests.gypi This should avoid possible build flakiness. Found using this proposed ninja patch: https://github.com/martine/ninja/pull/1031 BUG=536641 Committed: https://crrev.com/6a65ae6ee1d7ed4ac5c4311ed2901c3ba9a4e598 Cr-Commit-Position: refs/heads/master@{#351063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371073002/1
5 years, 2 months ago (2015-09-28 11:23:31 UTC) #2
Mostyn Bramley-Moore
@Jochen: please take a look at this build flakiness fixup.
5 years, 2 months ago (2015-09-28 11:25:41 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-28 11:39:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 13:35:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371073002/1
5 years, 2 months ago (2015-09-28 13:45:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 13:50:10 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 13:50:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a65ae6ee1d7ed4ac5c4311ed2901c3ba9a4e598
Cr-Commit-Position: refs/heads/master@{#351063}

Powered by Google App Engine
This is Rietveld 408576698