Issue 137103004: Fix an issue that surface texture is not reestablished after video gets interrupted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137103004: Fix an issue that surface texture is not reestablished after video gets interrupted (Closed)

Created:
6 years, 11 months ago by qinmin

Modified:
6 years, 11 months ago

Reviewers:
Miguel Garcia

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix an issue that surface texture is not reestablished after video gets interrupted When video gets interrupted by audio focus change, we sent an DidMediaPlayerPause IPC to WebMediaPlayer, and release the mediaplayer at the same time. However, when we want to resume the playback, WebMediaPlayer does not know that the mediaplayer needs to reestablish the surface texture. Instead of sending DidMediaPlayerPause, we should send MediaPlayerReleased IPC. See internal b/12362468 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245097

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	content/browser/media/android/browser_media_player_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/renderer/media/android/webmediaplayer_android.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/137103004/1

6 years, 11 months ago (2014-01-14 17:44:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/137103004/1

6 years, 11 months ago (2014-01-14 23:26:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/137103004/1

6 years, 11 months ago (2014-01-15 02:58:18 UTC) #5

Message was sent while issue was closed.

Change committed as 245097

Expand Messages | Collapse Messages