Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1371003002: Utilize VisibleSelectionTemplate template class in SelectionController (Closed)

Created:
5 years, 2 months ago by yosin_UTC9
Modified:
5 years, 2 months ago
Reviewers:
yoichio
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Utilize VisibleSelectionTemplate template class in SelectionController This patch utilizes |VisibleSelectionTemplate| template class in |SelectionController| class as replacement of |VisibleSelection::InDOMTree| and |VisibleSelection::InComposedTree| for a preparation of full version of |VisibleSelectionTemplate|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1363873004 BUG=513568 TEST=n/a; no behavior changes Committed: https://crrev.com/59fb12ff0a75637b5c785b420653cf1289b7c29c Cr-Commit-Position: refs/heads/master@{#351039}

Patch Set 1 : 2015-09-28T14:31:05 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -63 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionController.h View 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 18 chunks +94 lines, -63 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yosin_UTC9
PTAL
5 years, 2 months ago (2015-09-28 05:50:01 UTC) #2
yoichio
lgtm
5 years, 2 months ago (2015-09-28 05:55:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371003002/1
5 years, 2 months ago (2015-09-28 06:04:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 09:06:10 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 09:06:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59fb12ff0a75637b5c785b420653cf1289b7c29c
Cr-Commit-Position: refs/heads/master@{#351039}

Powered by Google App Engine
This is Rietveld 408576698