Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1370993008: Revert of [swarming] Isolate v8 testing. (Closed)

Created:
5 years, 2 months ago by danno
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, M-A Ruel
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [swarming] Isolate v8 testing. (patchset #8 id:140001 of https://codereview.chromium.org/1380593002/ ) Reason for revert: Prime suspect in breakage of V8 Linux -- no snap Original issue's description: > [swarming] Isolate v8 testing. > > Add gyp support and isolates for default test suites. > Add two default isolates, one (default) for using the > test suite collection we call "default" on the bots. One > (developer_default) for also supporting the way developers > call the driver (i.e. without argument, which includes > the unittests). > > BUG=chromium:535160 > LOG=n > > Committed: https://crrev.com/9bd83f58f29ab0c7c5b71b00bcb1df3a9e641f05 > Cr-Commit-Position: refs/heads/master@{#31081} TBR=tandrii@chromium.org,jochen@chromium.org,maruel@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:535160 Committed: https://crrev.com/280a6f8ec84327692a4dedf4edc1ea72f5d5ba73 Cr-Commit-Position: refs/heads/master@{#31084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -334 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
D test/cctest/cctest.isolate View 1 chunk +0 lines, -16 lines 0 comments Download
D test/default.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D test/default.isolate View 1 chunk +0 lines, -12 lines 0 comments Download
D test/developer_default.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D test/developer_default.isolate View 1 chunk +0 lines, -9 lines 0 comments Download
D test/intl/intl.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D test/intl/intl.isolate View 1 chunk +0 lines, -14 lines 0 comments Download
D test/message/message.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D test/message/message.isolate View 1 chunk +0 lines, -14 lines 0 comments Download
D test/mjsunit/mjsunit.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D test/mjsunit/mjsunit.isolate View 1 chunk +0 lines, -23 lines 0 comments Download
D test/preparser/preparser.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D test/preparser/preparser.isolate View 1 chunk +0 lines, -14 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
D test/unittests/unittests.isolate View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/testrunner/testrunner.isolate View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
Created Revert of [swarming] Isolate v8 testing.
5 years, 2 months ago (2015-10-02 15:44:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370993008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370993008/1
5 years, 2 months ago (2015-10-02 15:44:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 15:45:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/280a6f8ec84327692a4dedf4edc1ea72f5d5ba73 Cr-Commit-Position: refs/heads/master@{#31084}
5 years, 2 months ago (2015-10-02 15:45:36 UTC) #4
Michael Achenbach
5 years, 2 months ago (2015-10-02 17:40:36 UTC) #5
Message was sent while issue was closed.
lgtm, thanks for reverting. Looks like external_startup_data is also 1 in nosnap
builds - where there's no startup data. Will add and extra condition...

Powered by Google App Engine
This is Rietveld 408576698