Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1370993002: Utilize VisibleSelectionTemplate template class in VisibleSelectionTest (Closed)

Created:
5 years, 2 months ago by yosin_UTC9
Modified:
5 years, 2 months ago
Reviewers:
yoichio
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Utilize VisibleSelectionTemplate template class in VisibleSelectionTest This patch utilizes |VisibleSelectionTemplate| template class in |VisibleSelectionTest| class as replacement of |VisibleSelection::InDOMTree| and |VisibleSelection::InComposedTree| for a preparation of full version of |VisibleSelectionTemplate|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1363873004 BUG=513568 TEST=n/a; no behavior changes Committed: https://crrev.com/b9a7440b79d46c863ec0e4c53b9729a38d4ec12d Cr-Commit-Position: refs/heads/master@{#351060}

Patch Set 1 : 2015-09-28T14:07:37 #

Patch Set 2 : 2015-09-28T14:47:10 Reduce diff size #

Total comments: 2

Patch Set 3 : 2015-09-28T15:33:19 Make testComposedTreePositionsToEqualToDOMTreePositions() as static void instead of static class member #

Patch Set 4 : 2015-09-28T19:32:49 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -46 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 2 3 1 chunk +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 1 2 10 chunks +64 lines, -26 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
yosin_UTC9
PTAL
5 years, 2 months ago (2015-09-28 06:05:18 UTC) #3
yoichio
https://codereview.chromium.org/1370993002/diff/40001/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp File third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp (right): https://codereview.chromium.org/1370993002/diff/40001/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp#newcode55 third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp:55: void VisibleSelectionTest::testComposedTreePositionsToEqualToDOMTreePositions(const VisibleSelection& selection, const VisibleSelectionInComposedTree& selectionInComposedTree) Just use ...
5 years, 2 months ago (2015-09-28 06:12:27 UTC) #4
yosin_UTC9
PTAL https://codereview.chromium.org/1370993002/diff/40001/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp File third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp (right): https://codereview.chromium.org/1370993002/diff/40001/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp#newcode55 third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp:55: void VisibleSelectionTest::testComposedTreePositionsToEqualToDOMTreePositions(const VisibleSelection& selection, const VisibleSelectionInComposedTree& selectionInComposedTree) On ...
5 years, 2 months ago (2015-09-28 06:34:41 UTC) #5
yoichio
lgtm
5 years, 2 months ago (2015-09-28 07:41:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370993002/60001
5 years, 2 months ago (2015-09-28 07:44:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/75017)
5 years, 2 months ago (2015-09-28 09:37:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370993002/60001
5 years, 2 months ago (2015-09-28 09:56:58 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104223) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-09-28 10:02:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370993002/60001
5 years, 2 months ago (2015-09-28 10:03:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104225) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-09-28 10:08:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370993002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370993002/80001
5 years, 2 months ago (2015-09-28 10:33:37 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 2 months ago (2015-09-28 12:50:43 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 12:51:39 UTC) #23
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b9a7440b79d46c863ec0e4c53b9729a38d4ec12d
Cr-Commit-Position: refs/heads/master@{#351060}

Powered by Google App Engine
This is Rietveld 408576698