Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1370953002: content: Remove dump-render-tree switch. (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 2 months ago
CC:
Avi (use Gerrit), chromium-reviews, darin-cc_chromium.org, Dirk Pranke, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Remove dump-render-tree switch. All the consumers of dump-render-tree were converted to run-layout-test, so we can removes this switch now. BUG=453252 R=jochen@chromium.org,ojan@chromium.org Committed: https://crrev.com/2eb4a6be7b92c44bfeee2cb69ad118d7cb8e44fa Cr-Commit-Position: refs/heads/master@{#351329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/shell/common/shell_switches.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
tfarina
5 years, 2 months ago (2015-09-27 19:11:00 UTC) #1
ojan
Lgtm! Before committing this, can you send a simple short PSA to blink-dev in case ...
5 years, 2 months ago (2015-09-27 19:42:34 UTC) #2
tfarina
On 2015/09/27 19:42:34, ojan wrote: > Lgtm! Before committing this, can you send a simple ...
5 years, 2 months ago (2015-09-28 05:40:47 UTC) #3
jochen (gone - plz use gerrit)
On 2015/09/28 at 05:40:47, tfarina wrote: > On 2015/09/27 19:42:34, ojan wrote: > > Lgtm! ...
5 years, 2 months ago (2015-09-28 11:33:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370953002/1
5 years, 2 months ago (2015-09-28 17:14:38 UTC) #6
ojan
I totally forgot about documentation. Whoops. :) I found the following three using a google ...
5 years, 2 months ago (2015-09-28 17:29:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/108862)
5 years, 2 months ago (2015-09-28 20:19:37 UTC) #9
tfarina
On 2015/09/28 17:29:27, ojan wrote: > I totally forgot about documentation. Whoops. :) > > ...
5 years, 2 months ago (2015-09-29 15:59:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370953002/1
5 years, 2 months ago (2015-09-29 15:59:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 16:16:54 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 16:17:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2eb4a6be7b92c44bfeee2cb69ad118d7cb8e44fa
Cr-Commit-Position: refs/heads/master@{#351329}

Powered by Google App Engine
This is Rietveld 408576698