Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1370943002: [builtins] Fix ToString in Array.prototype.join. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix ToString in Array.prototype.join. The internal ConvertToString helper was using the wrong ToPrimitive, actually the old ES5 like DefaultString, and it also prematurely optimized for no real benefit. BUG=v8:4307 LOG=n Committed: https://crrev.com/1ce206872ff272af1c7da64afda4101b15f1726c Cr-Commit-Position: refs/heads/master@{#30956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/array.js View 2 chunks +6 lines, -5 lines 0 comments Download
M src/runtime.js View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Jaro, Another obvious one. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-09-28 04:50:50 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-09-28 05:01:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370943002/1
5 years, 2 months ago (2015-09-28 05:02:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 05:03:34 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 05:03:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ce206872ff272af1c7da64afda4101b15f1726c
Cr-Commit-Position: refs/heads/master@{#30956}

Powered by Google App Engine
This is Rietveld 408576698