ChromeOS: fix user signin by alias.

chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h"
 
 #include "ash/system/chromeos/devicetype_utils.h"
 #include "base/bind.h"
 #include "base/guid.h"
 #include "base/logging.h"
@@ skipping 497 matching lines @@
   else
     frame_error_ = net::ERR_INTERNET_DISCONNECTED;
 
   LOG(ERROR) << "Gaia webview error: " << error_reason_str;
   NetworkError::ErrorReason error_reason =
       NetworkError::ERROR_REASON_FRAME_ERROR;
   frame_state_ = FRAME_STATE_ERROR;
   UpdateState(error_reason);
 }
 
+std::string GaiaScreenHandler::GetCanonicalEmail(
+    const std::string& authenticated_email,
+    const std::string& gaia_id) const {
+  const std::string sanitized_email = gaia::SanitizeEmail(authenticated_email);
+
+  const std::string canonicalized_email =
+      gaia::CanonicalizeEmail(sanitized_email);
+  user_manager::UserManager* user_manager = user_manager::UserManager::Get();
+  if (user_manager && !user_manager->IsKnownUser(canonicalized_email)) {
+    std::string old_email;
+    if (user_manager->GetKnownUserCanonicalEmail(gaia_id, &old_email)) {
+      if (old_email != canonicalized_email) {
+        LOG(WARNING) << "Existing user '" << old_email

[achuithb, 2015/09/29 18:18:42]

Should we make this LOG(INFO)?

Also, should we add UMA stats for this event?

[Alexander Alekseev, 2015/09/29 19:02:07]

LOG(INFO) is prohibited by precommit hooks.
So you think we should still use INFO?

[achuithb, 2015/09/29 19:07:48]

Doesn't feel like a WARNING, but I guess it's ok.

What about the UMA stat?

+                     << "' authenticated by alias '" << canonicalized_email
+                     << "'.";
+        return old_email;
+      }
+    }
+  }
+  return sanitized_email;

[achuithb, 2015/09/29 18:18:42]

The names are a bit confusing.

This method is called GetCanonicalEmail, you have variables, sanitized_email,
canonicalized_email, old_email, authenticated_email, gaia_id. What is the
difference between all of these? Could we add a comment somewhere?

[Alexander Alekseev, 2015/09/29 19:02:07]

It actually is returning sanitized email for compatibility.
We should probably call Canonicalize() here, but currently we rely on GAIA to
return canonical e-mail.

On the other hand, UserContext returns canonicalized e-mail, so that KnownUsers
data is stored using canonicalized e-mails as ID.

This way, it all works because Canonicalize() is done on GAIA side ;)

I've added comment here.

+}
+
 void GaiaScreenHandler::HandleCompleteAuthentication(
     const std::string& gaia_id,
     const std::string& email,
     const std::string& password,
     const std::string& auth_code,
     bool using_saml,
     const std::string& gaps_cookie) {
   if (!Delegate())
     return;
 
   RecordGAIAFlowTypeHistogram();
 
   DCHECK(!email.empty());
   DCHECK(!gaia_id.empty());
   const std::string sanitized_email = gaia::SanitizeEmail(email);
   Delegate()->SetDisplayEmail(sanitized_email);
-  UserContext user_context(sanitized_email);
+
+  const std::string canonical_email = GetCanonicalEmail(email, gaia_id);
+  UserContext user_context(canonical_email);
   user_context.SetGaiaID(gaia_id);
   user_context.SetKey(Key(password));
   user_context.SetAuthCode(auth_code);
   user_context.SetAuthFlow(using_saml
                                ? UserContext::AUTH_FLOW_GAIA_WITH_SAML
                                : UserContext::AUTH_FLOW_GAIA_WITHOUT_SAML);
   user_context.SetGAPSCookie(gaps_cookie);
   Delegate()->CompleteLogin(user_context);
 }
 
@@ skipping 105 matching lines @@
     return;
 
   if (using_saml && !using_saml_api_)
     RecordSAMLScrapingVerificationResultInHistogram(true);
   RecordGAIAFlowTypeHistogram();
 
   DCHECK(!typed_email.empty());
   DCHECK(!gaia_id.empty());
   const std::string sanitized_email = gaia::SanitizeEmail(typed_email);
   Delegate()->SetDisplayEmail(sanitized_email);
-  UserContext user_context(sanitized_email);
+  const std::string canonical_email = GetCanonicalEmail(typed_email, gaia_id);
+  UserContext user_context(canonical_email);
   user_context.SetGaiaID(gaia_id);
   user_context.SetKey(Key(password));
   user_context.SetAuthFlow(using_saml
                                ? UserContext::AUTH_FLOW_GAIA_WITH_SAML
                                : UserContext::AUTH_FLOW_GAIA_WITHOUT_SAML);
   Delegate()->CompleteLogin(user_context);
 
   if (test_expects_complete_login_) {
     VLOG(2) << "Complete test login for " << typed_email
             << ", requested=" << test_user_;
@@ skipping 263 matching lines @@
 SigninScreenHandlerDelegate* GaiaScreenHandler::Delegate() {
   DCHECK(signin_screen_handler_);
   return signin_screen_handler_->delegate_;
 }
 
 void GaiaScreenHandler::SetSigninScreenHandler(SigninScreenHandler* handler) {
   signin_screen_handler_ = handler;
 }
 
 }  // namespace chromeos