src/compiler/bytecode-graph-builder.cc - Issue 1370893002: [Interpreter] Add support for short (16 bit) operands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1370893002: [Interpreter] Add support for short (16 bit) operands. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rename to kIdx16 and add support for architectures which don't support unaligned accesses. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/bytecode-graph-builder.cc

diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc

index 3158e8bfdc25c1e53ab0f7b1e56a33f0acd06531..814bc18285c08c403ab8619bd1b064cabfc73145 100644

--- a/src/compiler/bytecode-graph-builder.cc

+++ b/src/compiler/bytecode-graph-builder.cc

@@ -188,7 +188,7 @@ void BytecodeGraphBuilder::VisitLdaZero(

void BytecodeGraphBuilder::VisitLdaSmi8(

const interpreter::BytecodeArrayIterator& iterator) {

- Node* node = jsgraph()->Constant(iterator.GetSmi8Operand(0));

+ Node* node = jsgraph()->Constant(iterator.GetImmediateOperand(0));

environment()->BindAccumulator(node);

}