[Interpreter] Add support for short (16 bit) operands.

src/interpreter/bytecodes.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INTERPRETER_BYTECODES_H_
 #define V8_INTERPRETER_BYTECODES_H_
 
 #include <iosfwd>
 
 // Clients of this interface shouldn't depend on lots of interpreter internals.
 // Do not include anything from src/interpreter here!
 #include "src/utils.h"
 
 namespace v8 {
 namespace internal {
 namespace interpreter {
 
 // The list of operand types used by bytecodes.
-#define OPERAND_TYPE_LIST(V) \
-  V(None)                    \
-  V(Count)                   \
-  V(Imm8)                    \
-  V(Idx)                     \
-  V(Reg)
+#define OPERAND_TYPE_LIST(V)   \
+                               \
+  /* None operand. */          \
+  V(None, OperandSize::kNone)  \
+                               \
+  /* Byte operands. */         \
+  V(Count, OperandSize::kByte) \
+  V(Imm8, OperandSize::kByte)  \
+  V(Idx, OperandSize::kByte)   \
+  V(Reg, OperandSize::kByte)   \
+                               \
+  /* Wide operands. */         \
+  V(WideIdx, OperandSize::kWide)

[oth, 2015/09/28 09:21:25]

Wide is a loose term. It's currently a 16-bit operand, though there's a 32-bit
operand coming after this lands (ExtraWide).

Open question - can we clean up the names in this CL? Suggest putting the width
in the name. Should be fairly mechanical:

/OperandType::Count/OperandType::Count8/g
/OperandType::Idx/OperandType::Idx8/g
/OperandType::Reg/OperandType::Reg8/g
/OperandType::WideIdx/OperandType::Idx16/g

[rmcilroy, 2015/10/01 14:09:14]

Renamed OperandSize::kWide to OperandSize::kShort, and changed operand types to
include size as requested.

 
 // The list of bytecodes which are interpreted by the interpreter.
 #define BYTECODE_LIST(V)                                                   \
                                                                            \
   /* Loading the accumulator */                                            \
   V(LdaZero, OperandType::kNone)                                           \
   V(LdaSmi8, OperandType::kImm8)                                           \
   V(LdaConstant, OperandType::kIdx)                                        \
   V(LdaUndefined, OperandType::kNone)                                      \
   V(LdaNull, OperandType::kNone)                                           \
@@ skipping 44 matching lines @@
   /* Control Flow */                                                       \
   V(Jump, OperandType::kImm8)                                              \
   V(JumpConstant, OperandType::kIdx)                                       \
   V(JumpIfTrue, OperandType::kImm8)                                        \
   V(JumpIfTrueConstant, OperandType::kIdx)                                 \
   V(JumpIfFalse, OperandType::kImm8)                                       \
   V(JumpIfFalseConstant, OperandType::kIdx)                                \
   V(Return, OperandType::kNone)
 
 
+// Enumeration of the size classes of operand types used by bytecodes.
+enum class OperandSize : uint8_t {
+  kNone = 0,
+  kByte = 1,
+  kWide = 2,

[oth, 2015/09/28 09:21:25]

More descriptive names to avoid wide? kOneByte kTwoByte

[rmcilroy, 2015/10/01 14:09:14]

Made it kByte, kShort and will be kLong for 32.

+};
+
+
 // Enumeration of operand types used by bytecodes.
 enum class OperandType : uint8_t {
-#define DECLARE_OPERAND_TYPE(Name) k##Name,
+#define DECLARE_OPERAND_TYPE(Name, _) k##Name,
   OPERAND_TYPE_LIST(DECLARE_OPERAND_TYPE)
 #undef DECLARE_OPERAND_TYPE
-#define COUNT_OPERAND_TYPES(x) +1
+#define COUNT_OPERAND_TYPES(x, _) +1
   // The COUNT_OPERAND macro will turn this into kLast = -1 +1 +1... which will
   // evaluate to the same value as the last operand.
   kLast = -1 OPERAND_TYPE_LIST(COUNT_OPERAND_TYPES)
 #undef COUNT_OPERAND_TYPES
 };
 
 
 // Enumeration of interpreter bytecodes.
 enum class Bytecode : uint8_t {
 #define DECLARE_BYTECODE(Name, ...) k##Name,
@@ skipping 57 matching lines @@
 
   // Returns bytecode for |value|.
   static Bytecode FromByte(uint8_t value);
 
   // Returns the number of operands expected by |bytecode|.
   static int NumberOfOperands(Bytecode bytecode);
 
   // Return the i-th operand of |bytecode|.
   static OperandType GetOperandType(Bytecode bytecode, int i);
 
+  // Returns the offset of the i-th operand of |bytecode| relative to the start
+  // of the bytecode.
+  static int GetOperandOffset(Bytecode bytecode, int i);
+
   // Returns the size of the bytecode including its operands.
   static int Size(Bytecode bytecode);
 
-  // The maximum number of operands across all bytecodes.
-  static int MaximumNumberOfOperands();
+  // Returns the size of operand.
+  static OperandSize SizeOfOperand(OperandType operand);
 
-  // Maximum size of a bytecode and its operands.
-  static int MaximumSize();
+  // Converts bytes[0] and bytes[1] to a 16 bit wide operand value.
+  static uint16_t WideOperandFromBytes(const uint8_t* bytes);
+
+  // Converts 16 bit wide |operand| into bytes_out[0] and bytes_out[1].
+  static void WideOperandToBytes(uint16_t operand, uint8_t* bytes_out);
 
   // Decode a single bytecode and operands to |os|.
   static std::ostream& Decode(std::ostream& os, const uint8_t* bytecode_start,
                               int number_of_parameters);
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(Bytecodes);
 };
 
 std::ostream& operator<<(std::ostream& os, const Bytecode& bytecode);
 std::ostream& operator<<(std::ostream& os, const OperandType& operand_type);
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_INTERPRETER_BYTECODES_H_