[Android] remount file system as writeable when failing to push files to external storage

[Android] remount file system as writeable when failing to push files to external storage

There is a problem on A1 devices where sdcard/ is read only. This remounts / with write
permission to push files to /sdcard then resets it to read only.

BUG=

Committed: https://crrev.com/4597a226b6c75363c2b065e6de511bdda2042cf8
Cr-Commit-Position: refs/heads/master@{#351144}

[rnephew (Reviews Here), 2015-09-25 23:07:13]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2015-09-28 08:30:47]

As mentioned offline, this should happen in provision_devices, not in
device_utils.

[rnephew (Reviews Here), 2015-09-28 17:57:24]

On 2015/09/28 08:30:47, jbudorick wrote:
> As mentioned offline, this should happen in provision_devices, not in
> device_utils.

Moved to provision_devices.

[jbudorick, 2015-09-28 18:01:18]

https://codereview.chromium.org/1370873002/diff/20001/build/android/provision...
File build/android/provision_devices.py (right):

https://codereview.chromium.org/1370873002/diff/20001/build/android/provision...
build/android/provision_devices.py:137: # Write a file with random name to
$EXTERNAL_STORAGE to test writability.
Use DeviceTempFile with dir=device.GetExternalStoragePath()

[rnephew (Reviews Here), 2015-09-28 18:34:06]

https://codereview.chromium.org/1370873002/diff/20001/build/android/provision...
File build/android/provision_devices.py (right):

https://codereview.chromium.org/1370873002/diff/20001/build/android/provision...
build/android/provision_devices.py:137: # Write a file with random name to
$EXTERNAL_STORAGE to test writability.
On 2015/09/28 18:01:17, jbudorick wrote:
> Use DeviceTempFile with dir=device.GetExternalStoragePath()

Done.

[rnephew (Reviews Here), 2015-09-28 18:36:37]

Talking to Ben, they also saw this issue in clusterfuzz, and it can also be
solved by just adding an actual SD card to the a1 device.

[jbudorick, 2015-09-28 18:40:03]

On 2015/09/28 at 18:36:37, rnephew wrote:
> Talking to Ben, they also saw this issue in clusterfuzz, and it can also be
solved by just adding an actual SD card to the a1 device.

labs did that to no apparent effect.

[jbudorick, 2015-09-28 18:45:00]

lgtm w/ nits

https://codereview.chromium.org/1370873002/diff/40001/build/android/provision...
File build/android/provision_devices.py (right):

https://codereview.chromium.org/1370873002/diff/40001/build/android/provision...
build/android/provision_devices.py:138: with
device_temp_file.DeviceTempFile(device.adb, suffix='.sh',
nit: wrong indent style

https://codereview.chromium.org/1370873002/diff/40001/build/android/provision...
build/android/provision_devices.py:145: with
device_temp_file.DeviceTempFile(device.adb, suffix='.sh',
same

[rnephew (Reviews Here), 2015-09-28 19:04:40]

https://codereview.chromium.org/1370873002/diff/40001/build/android/provision...
File build/android/provision_devices.py (right):

https://codereview.chromium.org/1370873002/diff/40001/build/android/provision...
build/android/provision_devices.py:138: with
device_temp_file.DeviceTempFile(device.adb, suffix='.sh',
On 2015/09/28 18:44:59, jbudorick wrote:
> nit: wrong indent style

Done.

https://codereview.chromium.org/1370873002/diff/40001/build/android/provision...
build/android/provision_devices.py:145: with
device_temp_file.DeviceTempFile(device.adb, suffix='.sh',
On 2015/09/28 18:44:59, jbudorick wrote:
> same

Done.

[rnephew (Reviews Here), 2015-09-28 19:04:44]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2015-09-28 19:04:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1370873002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-09-28 19:14:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370873002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370873002/60001

[commit-bot: I haz the power, 2015-09-28 21:00:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-28 21:02:45]

Patchset 4 (id:??) landed as
https://crrev.com/4597a226b6c75363c2b065e6de511bdda2042cf8
Cr-Commit-Position: refs/heads/master@{#351144}