Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: src/typing.cc

Issue 137083002: Get rid of ContextualMode for call ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Restore HCallGlobal until a follow-up CL Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/type-info.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 512 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 } 523 }
524 524
525 RECURSE(Visit(expr->obj())); 525 RECURSE(Visit(expr->obj()));
526 RECURSE(Visit(expr->key())); 526 RECURSE(Visit(expr->key()));
527 527
528 // We don't know anything about the result type. 528 // We don't know anything about the result type.
529 } 529 }
530 530
531 531
532 void AstTyper::VisitCall(Call* expr) { 532 void AstTyper::VisitCall(Call* expr) {
533 Expression* callee = expr->expression();
534 Property* prop = callee->AsProperty();
535 ContextualMode contextual_mode = prop == NULL ? CONTEXTUAL : NOT_CONTEXTUAL;
536 // Collect type feedback. 533 // Collect type feedback.
537 expr->RecordTypeFeedback(oracle(), contextual_mode); 534 expr->RecordTypeFeedback(oracle());
538 535
539 RECURSE(Visit(expr->expression())); 536 RECURSE(Visit(expr->expression()));
540 ZoneList<Expression*>* args = expr->arguments(); 537 ZoneList<Expression*>* args = expr->arguments();
541 for (int i = 0; i < args->length(); ++i) { 538 for (int i = 0; i < args->length(); ++i) {
542 Expression* arg = args->at(i); 539 Expression* arg = args->at(i);
543 RECURSE(Visit(arg)); 540 RECURSE(Visit(arg));
544 } 541 }
545 542
546 VariableProxy* proxy = expr->expression()->AsVariableProxy(); 543 VariableProxy* proxy = expr->expression()->AsVariableProxy();
547 if (proxy != NULL && proxy->var()->is_possibly_eval(isolate())) { 544 if (proxy != NULL && proxy->var()->is_possibly_eval(isolate())) {
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
792 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 789 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
793 } 790 }
794 791
795 792
796 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 793 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
797 RECURSE(Visit(stmt->body())); 794 RECURSE(Visit(stmt->body()));
798 } 795 }
799 796
800 797
801 } } // namespace v8::internal 798 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/type-info.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698