Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1370733002: Revert of Scale large notification icons according to device settings. (Closed)

Created:
5 years, 2 months ago by Theresa
Modified:
5 years, 2 months ago
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Scale large notification icons according to device settings. (patchset #3 id:40001 of https://codereview.chromium.org/1362943002/ ) Reason for revert: NotificationUIManagerTest#testShowNotificationWithIcon failing on instrumentation-nakasi-clankium and occam-svlete-clankium after this change: https://uberchromegw.corp.google.com/i/internal.client.clank/builders/instrumentation-occam-svelte-clankium/builds/1365 https://uberchromegw.corp.google.com/i/internal.client.clank/builders/instrumentation-nakasi-clankium/builds/1550 Original issue's description: > Scale large notification icons according to device settings. > > Previously we would directly pass developer-provided icons on to the > Android NotificationManager, but this has led to OOM errors on devices > with less memory when developers provide, supposedly, large icons. > > Starting from this CL, we ensure that icons are at most the size at > which they will be presented to the user. > > BUG=529980 > > Committed: https://crrev.com/c409a15aec57abe523fd57e4a3b8eb98cce5506e > Cr-Commit-Position: refs/heads/master@{#350514} TBR=mvanouwerkerk@chromium.org,peter@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=529980 Committed: https://crrev.com/c1695937778f8bc9ebc699404130b1a17a76f48f Cr-Commit-Position: refs/heads/master@{#350852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -109 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java View 7 chunks +40 lines, -54 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java View 3 chunks +2 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Theresa
Created Revert of Scale large notification icons according to device settings.
5 years, 2 months ago (2015-09-25 17:02:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370733002/1
5 years, 2 months ago (2015-09-25 17:04:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 17:05:30 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 17:06:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1695937778f8bc9ebc699404130b1a17a76f48f
Cr-Commit-Position: refs/heads/master@{#350852}

Powered by Google App Engine
This is Rietveld 408576698