DescriptionRevert of Scale large notification icons according to device settings. (patchset #3 id:40001 of https://codereview.chromium.org/1362943002/ )
Reason for revert:
NotificationUIManagerTest#testShowNotificationWithIcon failing on instrumentation-nakasi-clankium and occam-svlete-clankium after this change:
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/instrumentation-occam-svelte-clankium/builds/1365
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/instrumentation-nakasi-clankium/builds/1550
Original issue's description:
> Scale large notification icons according to device settings.
>
> Previously we would directly pass developer-provided icons on to the
> Android NotificationManager, but this has led to OOM errors on devices
> with less memory when developers provide, supposedly, large icons.
>
> Starting from this CL, we ensure that icons are at most the size at
> which they will be presented to the user.
>
> BUG=529980
>
> Committed: https://crrev.com/c409a15aec57abe523fd57e4a3b8eb98cce5506e
> Cr-Commit-Position: refs/heads/master@{#350514}
TBR=mvanouwerkerk@chromium.org,peter@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=529980
Committed: https://crrev.com/c1695937778f8bc9ebc699404130b1a17a76f48f
Cr-Commit-Position: refs/heads/master@{#350852}
Patch Set 1 #
Messages
Total messages: 4 (0 generated)
|