third_party/WebKit/Source/core/html/HTMLMediaElement.h - Issue 1370723002: Include viewport visibility checks for autoplay experiment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 1370723002: Include viewport visibility checks for autoplay experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

index ac28254cd852aee01b57f7372e8e80b0406f8e84..980f33aa210609a2dc9eb0c08ff41aa2e52a4cab 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

@@ -257,6 +257,10 @@ public:

virtual bool isHTMLAudioElement() const { return false; }

virtual bool isHTMLVideoElement() const { return false; }

+ // Temporary callback for crbug.com/487345,402044

+ void notifyPositionMayHaveChanged(const IntRect&);

+ void updatePositionNotificationRegistration();

protected:

HTMLMediaElement(const QualifiedName&, Document&);

~HTMLMediaElement() override;

@@ -446,6 +450,9 @@ private:

void audioTracksTimerFired(Timer<HTMLMediaElement>*);

+ // TODO(liberato): remove once autoplay gesture override experiment concludes.

+ void triggerAutoplayViewportCheckForTesting();

Timer<HTMLMediaElement> m_loadTimer;

Timer<HTMLMediaElement> m_progressEventTimer;

Timer<HTMLMediaElement> m_playbackProgressTimer;