third_party/WebKit/Source/core/html/AutoplayExperimentConfig.cpp - Issue 1370723002: Include viewport visibility checks for autoplay experiment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/AutoplayExperimentConfig.cpp

Issue 1370723002: Include viewport visibility checks for autoplay experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: identical to PS4 on 1329853004 (probably rebased) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes.html ('K') | « third_party/WebKit/Source/core/html/AutoplayExperimentConfig.h ('k') | third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h » ('j') | third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/AutoplayExperimentConfig.cpp

diff --git a/third_party/WebKit/Source/core/html/AutoplayExperimentConfig.cpp b/third_party/WebKit/Source/core/html/AutoplayExperimentConfig.cpp

index 8af7d9fb1b9c8b70131707e39e787cd88ef52db9..43a7f43139fca7f517f7cd40291594838319d684 100644

--- a/third_party/WebKit/Source/core/html/AutoplayExperimentConfig.cpp

+++ b/third_party/WebKit/Source/core/html/AutoplayExperimentConfig.cpp

@@ -16,6 +16,10 @@ AutoplayExperimentConfig::Mode AutoplayExperimentConfig::fromString(const String

value |= AutoplayExperimentConfig::Mode::ForVideo;

if (mode.contains("-foraudio"))

value |= AutoplayExperimentConfig::Mode::ForAudio;

+ if (mode.contains("-ifpagevisible"))

+ value |= AutoplayExperimentConfig::Mode::IfPageVisible;

+ if (mode.contains("-ifviewport"))

+ value |= AutoplayExperimentConfig::Mode::IfViewport;

if (mode.contains("-ifmuted"))

value |= AutoplayExperimentConfig::Mode::IfMuted;

if (mode.contains("-ifmobile"))