third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 1370723002: Include viewport visibility checks for autoplay experiment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1370723002: Include viewport visibility checks for autoplay experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: identical to PS4 on 1329853004 (probably rebased) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes.html ('K') | « third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt ('k') | third_party/WebKit/Source/core/html/AutoplayExperimentConfig.h » ('j') | third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index d27feb25d9efcfc466580789bf8518fade265c11..4d91158ca970894047046617a0c4494d31022e33 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -2448,6 +2448,11 @@ void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases, cons

ASSERT(!view->hasPendingSelection());

ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean

|| (RuntimeEnabledFeatures::slimmingPaintV2Enabled() && lifecycle().state() == DocumentLifecycle::CompositingForSlimmingPaintV2Clean));

+ // Temporary callback for crbug.com/487345,402044

+ // TODO(ojan): Make this more general to be used by PositionObserver

+ // and rAF throttling.

+ view->sendMediaPositionChangeNotifications();

}