third_party/WebKit/Source/core/testing/Internals.idl - Issue 1370723002: Include viewport visibility checks for autoplay experiment.

Side by Side Diff: third_party/WebKit/Source/core/testing/Internals.idl

Issue 1370723002: Include viewport visibility checks for autoplay experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: identical to PS4 on 1329853004 (probably rebased) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/layout/LayoutView.cpp ('K') | « third_party/WebKit/Source/core/testing/Internals.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 * Copyright (C) 2013 Apple Inc. All rights reserved.	3 * Copyright (C) 2013 Apple Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 *	8 *

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 335 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
346 ClientRectList focusRingRects(Element element);	346 ClientRectList focusRingRects(Element element);

347 ClientRectList outlineRects(Element element);	347 ClientRectList outlineRects(Element element);

348 void setCapsLockState(boolean enabled);	348 void setCapsLockState(boolean enabled);

349 void setSelectionPaintingWithoutSelectionGapsEnabled(boolean enabled);	349 void setSelectionPaintingWithoutSelectionGapsEnabled(boolean enabled);

350	350

351 // Returns whether the scrollbar was able to be shown or hidden; not all pla tforms	351 // Returns whether the scrollbar was able to be shown or hidden; not all pla tforms

352 // support overlay scrollbars.	352 // support overlay scrollbars.

353 bool setScrollbarVisibilityInScrollableArea(Node node, boolean visible);	353 bool setScrollbarVisibilityInScrollableArea(Node node, boolean visible);

354	354

355 void forceRestrictIFramePermissions();	355 void forceRestrictIFramePermissions();

	356

	357 [TypeChecking=Interface] void triggerAutoplayViewportCheck(HTMLMediaElement mediaElement);
	ojan 2015/10/01 06:14:26 We typically try to avoid adding one-off APIs like We typically try to avoid adding one-off APIs like this. Unfortunately, since we don't have a great track record of unittests, that means we handle things via regression tests (i.e. layout tests), which aren't very friendly to exposing the guts of the system. As an aside, feel free to write unittests whenever you can. We're happy to have more unittests and fewer layout tests where it's not too onerous to get setup. Since this will go away when we remove the experiment code, I'm OK with taking on this small bit of technical debt temporarily. But, please add a TODO(liberato) to remove this once the experiment is done in all the headers this method is defined in and in the calling code (i.e. in the layout test). esprehn 2015/10/01 07:04:15 You should be able to write a Sim test for this, s You should be able to write a Sim test for this, see DocumentLoadingRenderingTest. that would remove the need for this liberato (no reviews please) 2015/10/01 22:49:03 added the TODO. Show quoted text On 2015/10/01 06:14:26, ojan wrote: > We typically try to avoid adding one-off APIs like this. Unfortunately, since we > don't have a great track record of unittests, that means we handle things via > regression tests (i.e. layout tests), which aren't very friendly to exposing the > guts of the system. As an aside, feel free to write unittests whenever you can. > We're happy to have more unittests and fewer layout tests where it's not too > onerous to get setup. > > Since this will go away when we remove the experiment code, I'm OK with taking > on this small bit of technical debt temporarily. But, please add a > TODO(liberato) to remove this once the experiment is done in all the headers > this method is defined in and in the calling code (i.e. in the layout test). added the TODO. liberato (no reviews please) 2015/10/01 22:49:03 will look at this test, but for now leaving with T Show quoted text On 2015/10/01 07:04:15, esprehn wrote: > You should be able to write a Sim test for this, see > DocumentLoadingRenderingTest. that would remove the need for this will look at this test, but for now leaving with TODO.
356 };	358 };

OLD	NEW