Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 1370683003: Gallery: resize image data to overlay canvas size. (Closed)

Created:
5 years, 2 months ago by yawano
Modified:
5 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: resize image data to overlay canvas size. This issue was caused because overaly canvas size and main canvas size were different. Main canvas can show image with scaling. BUG=535854 TEST=manually tested as described in issue. Committed: https://crrev.com/3e97e9228b8fb6e0237300609314bf8b5a64149f Cr-Commit-Position: refs/heads/master@{#351028}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove blank line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M ui/file_manager/gallery/js/image_editor/image_adjust.js View 3 chunks +9 lines, -8 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_view.js View 1 1 chunk +23 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yawano
PTAL. Thank you! https://codereview.chromium.org/1370683003/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js File ui/file_manager/gallery/js/image_editor/image_view.js (right): https://codereview.chromium.org/1370683003/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js#newcode310 ui/file_manager/gallery/js/image_editor/image_view.js:310: This blank line is added for ...
5 years, 2 months ago (2015-09-25 11:07:59 UTC) #2
yawano
https://codereview.chromium.org/1370683003/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js File ui/file_manager/gallery/js/image_editor/image_view.js (right): https://codereview.chromium.org/1370683003/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js#newcode310 ui/file_manager/gallery/js/image_editor/image_view.js:310: This kind of thing should be done with separate ...
5 years, 2 months ago (2015-09-25 11:33:03 UTC) #3
fukino
lgtm.
5 years, 2 months ago (2015-09-28 06:20:00 UTC) #4
yawano
On 2015/09/28 06:20:00, fukino wrote: > lgtm. Thank you!
5 years, 2 months ago (2015-09-28 06:21:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370683003/20001
5 years, 2 months ago (2015-09-28 06:21:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 07:07:03 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 07:08:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e97e9228b8fb6e0237300609314bf8b5a64149f
Cr-Commit-Position: refs/heads/master@{#351028}

Powered by Google App Engine
This is Rietveld 408576698