Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: src/compiler/raw-machine-assembler.h

Issue 1370663002: [turbofan] Remove obsolete method from RawMachineAssembler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Sneak in comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/raw-machine-assembler.h
diff --git a/src/compiler/raw-machine-assembler.h b/src/compiler/raw-machine-assembler.h
index 7ea7b71d8c1af6b9278ba923b88bafd6bf75fd48..291f69f3b0a8d15966881b388d4f9414ece3b4cb 100644
--- a/src/compiler/raw-machine-assembler.h
+++ b/src/compiler/raw-machine-assembler.h
@@ -28,6 +28,10 @@ class Schedule;
// In order to create a schedule on-the-fly, the assembler keeps track of basic
// blocks by having one current basic block being populated and by referencing
// other basic blocks through the use of labels.
+//
+// Also note that the generated graph is only valid together with the generated
+// schedule, using one without the other is invalid as the graph is inherently
+// non-schedulable due to missing control and effect dependencies.
class RawMachineAssembler {
public:
class Label {
@@ -61,7 +65,6 @@ class RawMachineAssembler {
const MachineSignature* machine_sig() const {
return call_descriptor_->GetMachineSignature();
}
- BasicBlock* CurrentBlock();
// Finalizes the schedule and exports it to be used for code generation. Note
// that this RawMachineAssembler becomes invalid after export.
@@ -558,18 +561,17 @@ class RawMachineAssembler {
return AddNode(op, 0, static_cast<Node**>(nullptr));
}
- Node* AddNode(const Operator* op, Node* n1) { return AddNode(op, 1, &n1); }
-
template <class... TArgs>
- Node* AddNode(const Operator* op, Node* n1, Node* n2, TArgs... args) {
- Node* buffer[] = {n1, n2, args...};
- return AddNode(op, sizeof...(args) + 2, buffer);
+ Node* AddNode(const Operator* op, Node* n1, TArgs... args) {
+ Node* buffer[] = {n1, args...};
+ return AddNode(op, sizeof...(args) + 1, buffer);
}
private:
Node* MakeNode(const Operator* op, int input_count, Node** inputs);
BasicBlock* Use(Label* label);
BasicBlock* EnsureBlock(Label* label);
+ BasicBlock* CurrentBlock();
Isolate* isolate_;
Graph* graph_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698