Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1370663002: [turbofan] Remove obsolete method from RawMachineAssembler. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete method from RawMachineAssembler. R=jarin@chromium.org Committed: https://crrev.com/aa70b353886efee339189f6baf02c4e2449a6ca2 Cr-Commit-Position: refs/heads/master@{#30929}

Patch Set 1 #

Patch Set 2 : Sneak in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/compiler/raw-machine-assembler.h View 1 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-25 08:49:28 UTC) #1
Jarin
lgtm. Thanks!
5 years, 3 months ago (2015-09-25 08:50:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370663002/20001
5 years, 2 months ago (2015-09-25 09:07:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 09:29:30 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 09:29:41 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/aa70b353886efee339189f6baf02c4e2449a6ca2
Cr-Commit-Position: refs/heads/master@{#30929}

Powered by Google App Engine
This is Rietveld 408576698