Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1370643002: Revert of Make use of md5_check within process_resources.py (Closed)

Created:
5 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz, agrieve
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@md5-check-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make use of md5_check within process_resources.py (patchset #4 id:60001 of https://codereview.chromium.org/1357663002/ ) Reason for revert: breaks compilation, e.g. https://build.chromium.org/p/chromium/builders/Android/builds/46769/steps/compile/logs/stdio Original issue's description: > Make use of md5_check within process_resources.py > > This stops process_resources being run unnecessarily when only java source files > have changed. > > BUG=533442 > > Committed: https://crrev.com/03f85b7b1ff4f61a76630995709257968d8d7eed > Cr-Commit-Position: refs/heads/master@{#350777} TBR=pkotwicz@chromium.org,agrieve@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=533442 Committed: https://crrev.com/c5cdc35062bd6b16922074b2d8c5c1f8fc905b9c Cr-Commit-Position: refs/heads/master@{#350779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -72 lines) Patch
M build/android/gyp/process_resources.py View 8 chunks +23 lines, -72 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Make use of md5_check within process_resources.py
5 years, 2 months ago (2015-09-25 07:26:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370643002/1
5 years, 2 months ago (2015-09-25 07:27:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 07:27:59 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c5cdc35062bd6b16922074b2d8c5c1f8fc905b9c Cr-Commit-Position: refs/heads/master@{#350779}
5 years, 2 months ago (2015-09-25 07:29:00 UTC) #4
agrieve
5 years, 2 months ago (2015-09-25 14:37:15 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1361713003/ by agrieve@chromium.org.

The reason for reverting is: Fixed --proguard-file being marked as an input when
it's and output. Ensured "all" builds locally..

Powered by Google App Engine
This is Rietveld 408576698