Issue 137063014: Remove Node::containsForBindings() method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137063014: Remove Node::containsForBindings() method (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
haraken, esprehn

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove Node::containsForBindings() method Remove Node::containsForBindings() method and have the bindings call Node::containsIncludingShadowDOM() directly since containsForBindings() is merely a proxy to it. R=haraken, esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165320

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	Source/core/dom/Node.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	Source/core/dom/Node.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137063014/1

6 years, 11 months ago (2014-01-17 15:45:17 UTC) #3

Message was sent while issue was closed.

Change committed as 165320

Expand Messages | Collapse Messages