Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137063010: Mojo: Move platform handle/channel stuff in system to embedder namespace. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Move platform handle/channel stuff in system to embedder namespace. These things are exposed through the embedder API (and/or to be used by the embedder). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -90 lines) Patch
M mojo/common/test/multiprocess_test_base.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/common/test/multiprocess_test_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/common/test/multiprocess_test_base_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/embedder.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/embedder.cc View 2 chunks +25 lines, -43 lines 0 comments Download
M mojo/system/embedder_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/platform_channel_pair.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/platform_channel_pair.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/platform_channel_pair_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/platform_handle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/platform_handle.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/raw_channel.h View 2 chunks +1 line, -6 lines 0 comments Download
M mojo/system/raw_channel_posix.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/raw_channel_posix_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/raw_channel_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/remote_message_pipe_posix_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/scoped_platform_handle.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
I haven't figured out where I want the embedder directory to live yet (under mojo/? ...
6 years, 11 months ago (2014-01-16 19:34:08 UTC) #1
viettrungluu
6 years, 11 months ago (2014-01-16 20:16:39 UTC) #2
sky
LGTM - should these be moved to an embedder directory too?
6 years, 11 months ago (2014-01-16 20:20:49 UTC) #3
viettrungluu
6 years, 11 months ago (2014-01-16 20:30:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r245303 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698