Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137063005: Update more svg classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
pdr, pdr., Stephen Chennney
CC:
blink-reviews, Steve Block, krit, rjwright, alancutter (OOO until 2018), bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, Mike Lawther (Google), dstockwell, Timothy Loh, shans, f(malita), jchaffraix+rendering, darktears, Stephen Chennney, Eric Willigers, dino_apple.com, rwlbuis
Visibility:
Public.

Description

Update more svg classes to use OVERRIDE / FINAL when needed Update more svg classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. These were found using the chromium style clang plugin. R=pdr, schenney@chromium.org BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M Source/core/rendering/svg/RenderSVGContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElementInstance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedPathSegListPropertyTearOff.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedPropertyTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/properties/SVGAnimatedTransformListPropertyTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/properties/SVGMatrixTearOff.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGPathSegListPropertyTearOff.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/properties/SVGStaticPropertyTearOff.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-14 07:17:50 UTC) #1
pdr
On 2014/01/14 07:17:50, Chris Dumez wrote: LGTM!
6 years, 11 months ago (2014-01-14 07:18:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137063005/1
6 years, 11 months ago (2014-01-14 07:23:10 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 08:45:42 UTC) #4
Message was sent while issue was closed. 
Change committed as 165045

Powered by Google App Engine
This is Rietveld 408576698