Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2204)

Unified Diff: android_webview/native/aw_settings.cc

Issue 1370603002: Make some global pointers const void* const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_settings.cc
diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc
index 56bb3a8d8a695353798139980a343f8f35cd586c..753a9e1292cf210895af6e80a266e51b36de8c5a 100644
--- a/android_webview/native/aw_settings.cc
+++ b/android_webview/native/aw_settings.cc
@@ -50,13 +50,13 @@ void PopulateFixedWebPreferences(WebPreferences* web_prefs) {
web_prefs->should_clear_document_background = false;
}
-}; // namespace
+const void* const kAwSettingsUserDataKey = &kAwSettingsUserDataKey;
-const void* kAwSettingsUserDataKey = &kAwSettingsUserDataKey;
+}; // namespace
class AwSettingsUserData : public base::SupportsUserData::Data {
public:
- AwSettingsUserData(AwSettings* ptr) : settings_(ptr) {}
+ explicit AwSettingsUserData(AwSettings* ptr) : settings_(ptr) {}
static AwSettings* GetSettings(content::WebContents* web_contents) {
if (!web_contents)
« no previous file with comments | « android_webview/browser/browser_view_renderer.cc ('k') | chrome/browser/android/bookmarks/partner_bookmarks_shim.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698