Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: components/domain_reliability/uploader.cc

Issue 1370603002: Make some global pointers const void* const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/domain_reliability/uploader.h" 5 #include "components/domain_reliability/uploader.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/metrics/sparse_histogram.h" 9 #include "base/metrics/sparse_histogram.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
11 #include "base/supports_user_data.h" 11 #include "base/supports_user_data.h"
12 #include "components/data_use_measurement/core/data_use_user_data.h" 12 #include "components/data_use_measurement/core/data_use_user_data.h"
13 #include "components/domain_reliability/util.h" 13 #include "components/domain_reliability/util.h"
14 #include "net/base/load_flags.h" 14 #include "net/base/load_flags.h"
15 #include "net/base/net_errors.h" 15 #include "net/base/net_errors.h"
16 #include "net/http/http_response_headers.h" 16 #include "net/http/http_response_headers.h"
17 #include "net/http/http_util.h" 17 #include "net/http/http_util.h"
18 #include "net/url_request/url_fetcher.h" 18 #include "net/url_request/url_fetcher.h"
19 #include "net/url_request/url_fetcher_delegate.h" 19 #include "net/url_request/url_fetcher_delegate.h"
20 #include "net/url_request/url_request_context_getter.h" 20 #include "net/url_request/url_request_context_getter.h"
21 21
22 namespace domain_reliability { 22 namespace domain_reliability {
23 23
24 namespace { 24 namespace {
25 25
26 const char* kJsonMimeType = "application/json; charset=utf-8"; 26 const char kJsonMimeType[] = "application/json; charset=utf-8";
27 27
28 class UploadUserData : public base::SupportsUserData::Data { 28 class UploadUserData : public base::SupportsUserData::Data {
29 public: 29 public:
30 static net::URLFetcher::CreateDataCallback CreateCreateDataCallback() { 30 static net::URLFetcher::CreateDataCallback CreateCreateDataCallback() {
31 return base::Bind(&UploadUserData::CreateUploadUserData); 31 return base::Bind(&UploadUserData::CreateUploadUserData);
32 } 32 }
33 33
34 static const void* kUserDataKey; 34 static const void* const kUserDataKey;
35 35
36 private: 36 private:
37 static base::SupportsUserData::Data* CreateUploadUserData() { 37 static base::SupportsUserData::Data* CreateUploadUserData() {
38 return new UploadUserData(); 38 return new UploadUserData();
39 } 39 }
40 }; 40 };
41 41
42 const void* UploadUserData::kUserDataKey = 42 const void* const UploadUserData::kUserDataKey =
43 static_cast<const void*>(&UploadUserData::kUserDataKey); 43 &UploadUserData::kUserDataKey;
44 44
45 class DomainReliabilityUploaderImpl 45 class DomainReliabilityUploaderImpl
46 : public DomainReliabilityUploader, net::URLFetcherDelegate { 46 : public DomainReliabilityUploader, net::URLFetcherDelegate {
47 public: 47 public:
48 DomainReliabilityUploaderImpl( 48 DomainReliabilityUploaderImpl(
49 MockableTime* time, 49 MockableTime* time,
50 const scoped_refptr< 50 const scoped_refptr<
51 net::URLRequestContextGetter>& url_request_context_getter) 51 net::URLRequestContextGetter>& url_request_context_getter)
52 : time_(time), 52 : time_(time),
53 url_request_context_getter_(url_request_context_getter), 53 url_request_context_getter_(url_request_context_getter),
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 new DomainReliabilityUploaderImpl(time, url_request_context_getter)); 164 new DomainReliabilityUploaderImpl(time, url_request_context_getter));
165 } 165 }
166 166
167 // static 167 // static
168 bool DomainReliabilityUploader::URLRequestIsUpload( 168 bool DomainReliabilityUploader::URLRequestIsUpload(
169 const net::URLRequest& request) { 169 const net::URLRequest& request) {
170 return request.GetUserData(UploadUserData::kUserDataKey) != nullptr; 170 return request.GetUserData(UploadUserData::kUserDataKey) != nullptr;
171 } 171 }
172 172
173 } // namespace domain_reliability 173 } // namespace domain_reliability
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698