Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: chrome/browser/ui/views/download/download_feedback_dialog_view.cc

Issue 1370603002: Make some global pointers const void* const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/download/download_feedback_dialog_view.h" 5 #include "chrome/browser/ui/views/download/download_feedback_dialog_view.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/supports_user_data.h" 9 #include "base/supports_user_data.h"
10 #include "chrome/browser/platform_util.h" 10 #include "chrome/browser/platform_util.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/common/pref_names.h" 12 #include "chrome/common/pref_names.h"
13 #include "chrome/grit/chromium_strings.h" 13 #include "chrome/grit/chromium_strings.h"
14 #include "chrome/grit/generated_resources.h" 14 #include "chrome/grit/generated_resources.h"
15 #include "components/constrained_window/constrained_window_views.h" 15 #include "components/constrained_window/constrained_window_views.h"
16 #include "content/public/browser/page_navigator.h" 16 #include "content/public/browser/page_navigator.h"
17 #include "ui/base/l10n/l10n_util.h" 17 #include "ui/base/l10n/l10n_util.h"
18 #include "ui/views/controls/link.h" 18 #include "ui/views/controls/link.h"
19 #include "ui/views/controls/message_box_view.h" 19 #include "ui/views/controls/message_box_view.h"
20 #include "ui/views/widget/widget.h" 20 #include "ui/views/widget/widget.h"
21 21
22 using content::OpenURLParams; 22 using content::OpenURLParams;
23 23
24 namespace { 24 namespace {
25 25
26 const void* kDialogStatusKey = &kDialogStatusKey; 26 const void* const kDialogStatusKey = &kDialogStatusKey;
27 27
28 class DialogStatusData : public base::SupportsUserData::Data { 28 class DialogStatusData : public base::SupportsUserData::Data {
29 public: 29 public:
30 DialogStatusData() : currently_shown_(false) {} 30 DialogStatusData() : currently_shown_(false) {}
31 ~DialogStatusData() override {} 31 ~DialogStatusData() override {}
32 bool currently_shown() const { return currently_shown_; } 32 bool currently_shown() const { return currently_shown_; }
33 void set_currently_shown(bool shown) { currently_shown_ = shown; } 33 void set_currently_shown(bool shown) { currently_shown_ = shown; }
34 private: 34 private:
35 bool currently_shown_; 35 bool currently_shown_;
36 }; 36 };
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 views::Link* source, int event_flags) { 153 views::Link* source, int event_flags) {
154 WindowOpenDisposition disposition = 154 WindowOpenDisposition disposition =
155 ui::DispositionFromEventFlags(event_flags); 155 ui::DispositionFromEventFlags(event_flags);
156 content::OpenURLParams params( 156 content::OpenURLParams params(
157 GURL(l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_PRIVACY_POLICY_URL)), 157 GURL(l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_PRIVACY_POLICY_URL)),
158 content::Referrer(), 158 content::Referrer(),
159 disposition == CURRENT_TAB ? NEW_FOREGROUND_TAB : disposition, 159 disposition == CURRENT_TAB ? NEW_FOREGROUND_TAB : disposition,
160 ui::PAGE_TRANSITION_LINK, false); 160 ui::PAGE_TRANSITION_LINK, false);
161 navigator_->OpenURL(params); 161 navigator_->OpenURL(params);
162 } 162 }
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | components/data_use_measurement/core/data_use_user_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698