Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Side by Side Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

Issue 1370603002: Make some global pointers const void* const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h" 5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 18 matching lines...) Expand all
29 scoped_ptr<BookmarkNode> partner_bookmarks_root; 29 scoped_ptr<BookmarkNode> partner_bookmarks_root;
30 bool loaded; 30 bool loaded;
31 31
32 PartnerModelKeeper() 32 PartnerModelKeeper()
33 : loaded(false) {} 33 : loaded(false) {}
34 }; 34 };
35 35
36 base::LazyInstance<PartnerModelKeeper> g_partner_model_keeper = 36 base::LazyInstance<PartnerModelKeeper> g_partner_model_keeper =
37 LAZY_INSTANCE_INITIALIZER; 37 LAZY_INSTANCE_INITIALIZER;
38 38
39 const void* kPartnerBookmarksShimUserDataKey = 39 const void* const kPartnerBookmarksShimUserDataKey =
40 &kPartnerBookmarksShimUserDataKey; 40 &kPartnerBookmarksShimUserDataKey;
41 41
42 // Dictionary keys for entries in the kPartnerBookmarksMapping pref. 42 // Dictionary keys for entries in the kPartnerBookmarksMapping pref.
43 static const char kMappingUrl[] = "url"; 43 const char kMappingUrl[] = "url";
44 static const char kMappingProviderTitle[] = "provider_title"; 44 const char kMappingProviderTitle[] = "provider_title";
45 static const char kMappingTitle[] = "mapped_title"; 45 const char kMappingTitle[] = "mapped_title";
46 46
47 static bool g_disable_partner_bookmarks_editing = false; 47 bool g_disable_partner_bookmarks_editing = false;
48 48
49 } // namespace 49 } // namespace
50 50
51 // static 51 // static
52 PartnerBookmarksShim* PartnerBookmarksShim::BuildForBrowserContext( 52 PartnerBookmarksShim* PartnerBookmarksShim::BuildForBrowserContext(
53 content::BrowserContext* browser_context) { 53 content::BrowserContext* browser_context) {
54 DCHECK_CURRENTLY_ON(BrowserThread::UI); 54 DCHECK_CURRENTLY_ON(BrowserThread::UI);
55 55
56 PartnerBookmarksShim* data = 56 PartnerBookmarksShim* data =
57 static_cast<PartnerBookmarksShim*>( 57 static_cast<PartnerBookmarksShim*>(
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 i != node_rename_remove_map_.end(); 279 i != node_rename_remove_map_.end();
280 ++i) { 280 ++i) {
281 base::DictionaryValue* dict = new base::DictionaryValue(); 281 base::DictionaryValue* dict = new base::DictionaryValue();
282 dict->SetString(kMappingUrl, i->first.url().spec()); 282 dict->SetString(kMappingUrl, i->first.url().spec());
283 dict->SetString(kMappingProviderTitle, i->first.provider_title()); 283 dict->SetString(kMappingProviderTitle, i->first.provider_title());
284 dict->SetString(kMappingTitle, i->second); 284 dict->SetString(kMappingTitle, i->second);
285 list.Append(dict); 285 list.Append(dict);
286 } 286 }
287 prefs_->Set(prefs::kPartnerBookmarkMappings, list); 287 prefs_->Set(prefs::kPartnerBookmarkMappings, list);
288 } 288 }
OLDNEW
« no previous file with comments | « android_webview/native/aw_settings.cc ('k') | chrome/browser/safe_browsing/download_feedback_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698