Make some global pointers const void* const.

base/debug/task_annotator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/task_annotator.h"
 
 #include "base/debug/alias.h"
 #include "base/pending_task.h"
 #include "base/trace_event/trace_event.h"
 #include "base/tracked_objects.h"
@@ skipping 27 matching lines @@
                           TRACE_ID_MANGLE(GetTaskTraceID(pending_task)),
                           TRACE_EVENT_FLAG_FLOW_IN,
                           "queue_duration",
                           queue_duration.InMilliseconds());
 
   // Before running the task, store the program counter where it was posted
   // and deliberately alias it to ensure it is on the stack if the task
   // crashes. Be careful not to assume that the variable itself will have the
   // expected value when displayed by the optimizer in an optimized build.
   // Look at a memory dump of the stack.
-  const void* program_counter = pending_task.posted_from.program_counter();
+  const void* const program_counter =

[brettw, 2015/09/25 04:51:25]

This one seems unnecessary. I usually prefer not to mark all the random local
variables const.

[Lei Zhang, 2015/09/25 05:35:39]

Reverted

+      pending_task.posted_from.program_counter();
   debug::Alias(&program_counter);
 
   pending_task.task.Run();
 
   stopwatch.Stop();
   tracked_objects::ThreadData::TallyRunOnNamedThreadIfTracking(
       pending_task, stopwatch);
 }
 
 uint64 TaskAnnotator::GetTaskTraceID(const PendingTask& task) const {
   return (static_cast<uint64>(task.sequence_num) << 32) |
          ((static_cast<uint64>(reinterpret_cast<intptr_t>(this)) << 32) >> 32);
 }
 
 }  // namespace debug
 }  // namespace base