Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: jingle/notifier/base/xmpp_connection.h

Issue 1370563002: Use FRIEND_TEST_ALL_PREFIXES instead of FRIEND_TEST. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_parser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: jingle/notifier/base/xmpp_connection.h
diff --git a/jingle/notifier/base/xmpp_connection.h b/jingle/notifier/base/xmpp_connection.h
index bc1ec2a1e48cd5191e30109236a4ab77e8d8dc29..946a6deb9fe59684eda85c99ef6c0e69907d8fca 100644
--- a/jingle/notifier/base/xmpp_connection.h
+++ b/jingle/notifier/base/xmpp_connection.h
@@ -22,7 +22,7 @@ class PreXmppAuth;
class XmlElement;
class XmppClientSettings;
class XmppTaskParentInterface;
-} // namespace
+} // namespace buzz
namespace jingle_glue {
class TaskPump;
@@ -80,6 +80,13 @@ class XmppConnection
~XmppConnection() override;
private:
+ FRIEND_TEST_ALL_PREFIXES(XmppConnectionTest, RaisedError);
+ FRIEND_TEST_ALL_PREFIXES(XmppConnectionTest, Connect);
+ FRIEND_TEST_ALL_PREFIXES(XmppConnectionTest, MultipleConnect);
+ FRIEND_TEST_ALL_PREFIXES(XmppConnectionTest, ConnectThenError);
+ FRIEND_TEST_ALL_PREFIXES(XmppConnectionTest,
+ TasksDontRunAfterXmppConnectionDestructor);
+
void OnStateChange(buzz::XmppEngine::State state);
void OnInputLog(const char* data, int len);
void OnOutputLog(const char* data, int len);
@@ -91,12 +98,6 @@ class XmppConnection
bool on_connect_called_;
Delegate* delegate_;
- FRIEND_TEST(XmppConnectionTest, RaisedError);
- FRIEND_TEST(XmppConnectionTest, Connect);
- FRIEND_TEST(XmppConnectionTest, MultipleConnect);
- FRIEND_TEST(XmppConnectionTest, ConnectThenError);
- FRIEND_TEST(XmppConnectionTest, TasksDontRunAfterXmppConnectionDestructor);
-
DISALLOW_COPY_AND_ASSIGN(XmppConnection);
};
« no previous file with comments | « base/json/json_parser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698