Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2040)

Side by Side Diff: src/effects/SkBlurImageFilter.cpp

Issue 137053003: Apply the CTM to filter parameters for 4 pixel-moving filters. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Fix displacement offsets, GM clipping, colors Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2011 The Android Open Source Project 2 * Copyright 2011 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBitmap.h" 8 #include "SkBitmap.h"
9 #include "SkBlurImageFilter.h" 9 #include "SkBlurImageFilter.h"
10 #include "SkColorPriv.h" 10 #include "SkColorPriv.h"
11 #include "SkFlattenableBuffers.h" 11 #include "SkFlattenableBuffers.h"
12 #include "SkGpuBlurUtils.h" 12 #include "SkGpuBlurUtils.h"
13 #include "SkBlurImage_opts.h" 13 #include "SkBlurImage_opts.h"
14 #if SK_SUPPORT_GPU 14 #if SK_SUPPORT_GPU
15 #include "GrContext.h" 15 #include "GrContext.h"
16 #include "SkImageFilterUtils.h" 16 #include "SkImageFilterUtils.h"
17 #endif 17 #endif
18 18
19 SkBlurImageFilter::SkBlurImageFilter(SkFlattenableReadBuffer& buffer) 19 SkBlurImageFilter::SkBlurImageFilter(SkFlattenableReadBuffer& buffer)
20 : INHERITED(1, buffer) { 20 : INHERITED(1, buffer) {
21 fSigma.fWidth = buffer.readScalar(); 21 fSigma.fX = buffer.readScalar();
22 fSigma.fHeight = buffer.readScalar(); 22 fSigma.fY = buffer.readScalar();
23 buffer.validate(SkScalarIsFinite(fSigma.fWidth) && 23 buffer.validate(SkScalarIsFinite(fSigma.fX) &&
24 SkScalarIsFinite(fSigma.fHeight) && 24 SkScalarIsFinite(fSigma.fY) &&
25 (fSigma.fWidth >= 0) && 25 (fSigma.fX >= 0) &&
26 (fSigma.fHeight >= 0)); 26 (fSigma.fY >= 0));
27 } 27 }
28 28
29 SkBlurImageFilter::SkBlurImageFilter(SkScalar sigmaX, 29 SkBlurImageFilter::SkBlurImageFilter(SkScalar sigmaX,
30 SkScalar sigmaY, 30 SkScalar sigmaY,
31 SkImageFilter* input, 31 SkImageFilter* input,
32 const CropRect* cropRect) 32 const CropRect* cropRect)
33 : INHERITED(input, cropRect), fSigma(SkSize::Make(sigmaX, sigmaY)) { 33 : INHERITED(input, cropRect), fSigma(SkVector::Make(sigmaX, sigmaY)) {
34 SkASSERT(sigmaX >= 0 && sigmaY >= 0); 34 SkASSERT(sigmaX >= 0 && sigmaY >= 0);
35 } 35 }
36 36
37 void SkBlurImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const { 37 void SkBlurImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {
38 this->INHERITED::flatten(buffer); 38 this->INHERITED::flatten(buffer);
39 buffer.writeScalar(fSigma.fWidth); 39 buffer.writeScalar(fSigma.fX);
40 buffer.writeScalar(fSigma.fHeight); 40 buffer.writeScalar(fSigma.fY);
41 } 41 }
42 42
43 enum BlurDirection { 43 enum BlurDirection {
44 kX, kY 44 kX, kY
45 }; 45 };
46 46
47 /** 47 /**
48 * 48 *
49 * In order to make memory accesses cache-friendly, we reorder the passes to 49 * In order to make memory accesses cache-friendly, we reorder the passes to
50 * use contiguous memory reads wherever possible. 50 * use contiguous memory reads wherever possible.
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 return false; 158 return false;
159 } 159 }
160 160
161 dst->setConfig(src.config(), srcBounds.width(), srcBounds.height()); 161 dst->setConfig(src.config(), srcBounds.width(), srcBounds.height());
162 dst->getBounds(&dstBounds); 162 dst->getBounds(&dstBounds);
163 dst->allocPixels(); 163 dst->allocPixels();
164 if (!dst->getPixels()) { 164 if (!dst->getPixels()) {
165 return false; 165 return false;
166 } 166 }
167 167
168 SkVector sigma;
169 ctm.mapVectors(&sigma, &fSigma, 1);
170
168 int kernelSizeX, kernelSizeX3, lowOffsetX, highOffsetX; 171 int kernelSizeX, kernelSizeX3, lowOffsetX, highOffsetX;
169 int kernelSizeY, kernelSizeY3, lowOffsetY, highOffsetY; 172 int kernelSizeY, kernelSizeY3, lowOffsetY, highOffsetY;
170 getBox3Params(fSigma.width(), &kernelSizeX, &kernelSizeX3, &lowOffsetX, &hig hOffsetX); 173 getBox3Params(sigma.x(), &kernelSizeX, &kernelSizeX3, &lowOffsetX, &highOffs etX);
171 getBox3Params(fSigma.height(), &kernelSizeY, &kernelSizeY3, &lowOffsetY, &hi ghOffsetY); 174 getBox3Params(sigma.y(), &kernelSizeY, &kernelSizeY3, &lowOffsetY, &highOffs etY);
172 175
173 if (kernelSizeX < 0 || kernelSizeY < 0) { 176 if (kernelSizeX < 0 || kernelSizeY < 0) {
174 return false; 177 return false;
175 } 178 }
176 179
177 if (kernelSizeX == 0 && kernelSizeY == 0) { 180 if (kernelSizeX == 0 && kernelSizeY == 0) {
178 src.copyTo(dst, dst->config()); 181 src.copyTo(dst, dst->config());
179 offset->fX = srcBounds.fLeft; 182 offset->fX = srcBounds.fLeft;
180 offset->fY = srcBounds.fTop; 183 offset->fY = srcBounds.fTop;
181 return true; 184 return true;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 SkBitmap input; 231 SkBitmap input;
229 if (!SkImageFilterUtils::GetInputResultGPU(getInput(0), proxy, src, ctm, &in put, offset)) { 232 if (!SkImageFilterUtils::GetInputResultGPU(getInput(0), proxy, src, ctm, &in put, offset)) {
230 return false; 233 return false;
231 } 234 }
232 GrTexture* source = input.getTexture(); 235 GrTexture* source = input.getTexture();
233 SkIRect rect; 236 SkIRect rect;
234 src.getBounds(&rect); 237 src.getBounds(&rect);
235 if (!this->applyCropRect(&rect, ctm)) { 238 if (!this->applyCropRect(&rect, ctm)) {
236 return false; 239 return false;
237 } 240 }
241 SkVector sigma;
242 ctm.mapVectors(&sigma, &fSigma, 1);
238 SkAutoTUnref<GrTexture> tex(SkGpuBlurUtils::GaussianBlur(source->getContext( ), 243 SkAutoTUnref<GrTexture> tex(SkGpuBlurUtils::GaussianBlur(source->getContext( ),
239 source, 244 source,
240 false, 245 false,
241 SkRect::Make(rect), 246 SkRect::Make(rect),
242 true, 247 true,
243 fSigma.width(), 248 sigma.x(),
244 fSigma.height())); 249 sigma.y()));
245 offset->fX = rect.fLeft; 250 offset->fX = rect.fLeft;
246 offset->fY = rect.fTop; 251 offset->fY = rect.fTop;
247 return SkImageFilterUtils::WrapTexture(tex, rect.width(), rect.height(), res ult); 252 return SkImageFilterUtils::WrapTexture(tex, rect.width(), rect.height(), res ult);
248 #else 253 #else
249 SkDEBUGFAIL("Should not call in GPU-less build"); 254 SkDEBUGFAIL("Should not call in GPU-less build");
250 return false; 255 return false;
251 #endif 256 #endif
252 } 257 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698