Issue 13705: Do not access WebInspector.panels.scripts panel while it's disabled in Chrome...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13705: Do not access WebInspector.panels.scripts panel while it's disabled in Chrome... (Closed)

Created:
12 years ago by Please use yurys#chromium.org

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, dglazkov, sgjesse, ojan

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Do not access WebInspector.panels.scripts panel while it's disabled in Chrome. BUG=5158 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6780 (by sgjesse@chromium.org)

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	third_party/WebKit/WebCore/inspector/front-end/Console.js	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/13705/diff/1/2 File third_party/WebKit/WebCore/inspector/front-end/Console.js (right): http://codereview.chromium.org/13705/diff/1/2#newcode271 Line 271: if (WebInspector.panels.scripts.paused) Maybe change condition to WebInspector.panels.scripts ...

12 years ago (2008-12-10 12:57:47 UTC) #2

Please use yurys#chromium.org

12 years ago (2008-12-10 14:53:38 UTC) #3

http://codereview.chromium.org/13705/diff/1/2
File third_party/WebKit/WebCore/inspector/front-end/Console.js (right):

http://codereview.chromium.org/13705/diff/1/2#newcode271
Line 271: if (WebInspector.panels.scripts.paused)
On 2008/12/10 12:57:48, Søren Gjesse wrote:
> Maybe change condition to 
> 
> WebInspector.panels.scripts && WebInspector.panels.scripts.paused
> 
> instead of commenting out the code.

Done.

http://codereview.chromium.org/13705/diff/1/2#newcode400
Line 400: if (WebInspector.panels.scripts.paused)
On 2008/12/10 12:57:48, Søren Gjesse wrote:
> See comment above.

Done.

Expand Messages | Collapse Messages

Issue 13705: Do not access WebInspector.panels.scripts panel while it's disabled in Chrome... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages