components/history/core/browser/history_backend.cc - Issue 1370493002: Enable history counting for time ranges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend.cc

Issue 1370493002: Enable history counting for time ranges. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_backend.cc

diff --git a/components/history/core/browser/history_backend.cc b/components/history/core/browser/history_backend.cc

index e4243bfee29fc040e19de2db9e05aa9fb6a9a38a..8257bebf06518a463a3800f3c8e888eeb18e2619 100644

--- a/components/history/core/browser/history_backend.cc

+++ b/components/history/core/browser/history_backend.cc

@@ -1045,10 +1045,12 @@ TypedUrlSyncableService* HistoryBackend::GetTypedUrlSyncableService() const {

// Statistics ------------------------------------------------------------------

-HistoryCountResult HistoryBackend::GetHistoryCount() {

+HistoryCountResult HistoryBackend::GetHistoryCount(const Time& begin_time,

+ const Time& end_time) {

HistoryCountResult result;

result.count = 0;

- result.success = db_ && db_->GetHistoryCount(&result.count);

+ result.success =

+ db_ && db_->GetHistoryCount(begin_time, end_time, &result.count);

return result;

}