third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h - Issue 1370453002: Introduce WebMediaSession

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 1370453002: Introduce WebMediaSession (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/platform/android/virtual/mediasession/media/mediasession/mediasession-constructor-expected.txt ('K') | « third_party/WebKit/LayoutTests/virtual/mediasession/media/mediasession/mediasession-constructor-expected.txt ('k') | third_party/WebKit/Source/core/loader/EmptyClients.h » ('j') | third_party/WebKit/Source/modules/mediasession/MediaSession.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h b/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

index 04f69dc90ae11fa549d599ca3d41f9e2fb6e1050..9dd469d9297ae312f38d15c46babf65ae7f0f322 100644

--- a/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

+++ b/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

@@ -185,6 +185,7 @@ private:

{

typename T::WebType result(adopt(e));

ScriptPromiseResolver* resolver = this->resolver();

+ ScriptState::Scope scope(resolver->scriptState());

whywhat 2015/10/13 15:59:04 nit: is this needed? shoulnd't this be part of a s

davve 2015/10/19 13:12:42 Gone now we're heading for DOMException instead.

if (!resolver->executionContext() || resolver->executionContext()->activeDOMObjectsAreStopped())

return;

resolver->reject(T::take(resolver, pass(result)));