third_party/WebKit/Source/modules/mediasession/MediaSession.idl - Issue 1370453002: Introduce WebMediaSession

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasession/MediaSession.idl

Issue 1370453002: Introduce WebMediaSession (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert throwing in the constructor; would needlessly complicate existing tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/mediasession/MediaSession.idl

diff --git a/third_party/WebKit/Source/modules/mediasession/MediaSession.idl b/third_party/WebKit/Source/modules/mediasession/MediaSession.idl

index 235604b3f20f4b98c5470611e3d8e68f8152db2e..7e0d39d1d3401710566ad242c1ec3ba84a5317ac 100644

--- a/third_party/WebKit/Source/modules/mediasession/MediaSession.idl

+++ b/third_party/WebKit/Source/modules/mediasession/MediaSession.idl

@@ -6,9 +6,10 @@

[

Constructor(),

+ ConstructorCallWith=ExecutionContext,

GarbageCollected,

RuntimeEnabled=MediaSession,

] interface MediaSession {

- void activate();

- void deactivate();

+ [CallWith=ScriptState] Promise<void> activate();

+ [CallWith=ScriptState] Promise<void> deactivate();

};