Introduce WebMediaSession

third_party/WebKit/Source/modules/mediasession/MediaSession.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/mediasession/MediaSession.h"
 
+#include "bindings/core/v8/CallbackPromiseAdapter.h"
+#include "bindings/core/v8/ScriptState.h"
+#include "core/frame/LocalDOMWindow.h"
+#include "core/frame/LocalFrame.h"
+#include "core/loader/FrameLoaderClient.h"
+#include "modules/mediasession/MediaSessionError.h"
+
 namespace blink {
 
-MediaSession* MediaSession::create()
+MediaSession::MediaSession(PassOwnPtr<WebMediaSession> webMediaSession)
+    : m_webMediaSession(webMediaSession)
 {
-    return new MediaSession;
+#if OS(ANDROID)
+    ASSERT(m_webMediaSession);
+#else
+    ASSERT(!m_webMediaSession);
+#endif // ANDROID
 }
 
-void MediaSession::activate()
+MediaSession* MediaSession::create(ScriptState* scriptState)

[mlamouri (slow - plz ping), 2015/09/28 15:16:03]

The ExecutionContext should be enough. It will give you the Document from which
you should be able to get all you need.

[davve, 2015/10/06 12:05:13]

Done.

 {
+    LocalDOMWindow* domWindow = scriptState->domWindow();
+    LocalFrame* frame = domWindow->frame();
+    FrameLoaderClient* client = frame->loader().client();
+    return new MediaSession(client->createWebMediaSession());
 }
 
-void MediaSession::deactivate()
+MediaSession* MediaSession::createForTesting(PassOwnPtr<WebMediaSession> webMediaSession)
 {
+    return new MediaSession(webMediaSession);
+}
+
+ScriptPromise MediaSession::activate(ScriptState* scriptState)
+{
+    ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();

[mlamouri (slow - plz ping), 2015/09/28 15:16:03]

Do you need to create the |promise| here? You could probably |return
resolver->promise();| at the end, couldn't you?

[davve, 2015/10/06 12:05:13]

Done.

+
+#if OS(ANDROID)

[mlamouri (slow - plz ping), 2015/09/28 15:16:03]

Could we avoid the ifdef and let that happen at a higher level? Or maybe fail if
m_webMediaSession is nullptr?

[davve, 2015/10/06 12:05:13]

Using m_webMediaSession != NULL wfm.

+    m_webMediaSession->activate(new CallbackPromiseAdapter<void, MediaSessionError>(resolver));
+#else
+    ScriptState::Scope scope(resolver->scriptState());
+    v8::Isolate* isolate = resolver->scriptState()->isolate();
+    resolver->reject(v8::Exception::Error(v8String(isolate, "Missing platform implementation.")));

[mlamouri (slow - plz ping), 2015/09/28 15:16:03]

Could you fail with a NotSupportedError?

[davve, 2015/10/06 12:05:13]

Done.

+#endif
+
+    return promise;
+}
+
+ScriptPromise MediaSession::deactivate(ScriptState* scriptState)
+{
+    ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();

[mlamouri (slow - plz ping), 2015/09/28 15:16:03]

ditto

[davve, 2015/10/06 12:05:13]

Done.

+
+#if OS(ANDROID)

[mlamouri (slow - plz ping), 2015/09/28 15:16:03]

ditto

[davve, 2015/10/06 12:05:13]

Done.

+    m_webMediaSession->deactivate(new CallbackPromiseAdapter<void, MediaSessionError>(resolver));
+#else
+    ScriptState::Scope scope(resolver->scriptState());
+    v8::Isolate* isolate = resolver->scriptState()->isolate();
+    resolver->reject(v8::Exception::Error(v8String(isolate, "Missing platform implementation.")));

[mlamouri (slow - plz ping), 2015/09/28 15:16:03]

ditto

[davve, 2015/10/06 12:05:13]

Done.

+#endif
+
+    return promise;
 }
 
 } // namespace blink