Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1370443007: Move SurfaceTexture construction to BackingStrategy. (Closed)

Created:
5 years, 2 months ago by liberato (no reviews please)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SurfaceTexture construction to BackingStrategy. In preparation for the zero copy backing strategy, this CL moves the construction of the surface texture to the BackingStrategy. BUG=536097 Committed: https://crrev.com/f8c4d4c1b6b5bad95caaa836acc004be7b587a27 Cr-Commit-Position: refs/heads/master@{#352649}

Patch Set 1 #

Total comments: 1

Patch Set 2 : git checkout zerocopy #

Patch Set 3 : rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -46 lines) Patch
M content/common/gpu/media/android_copying_backing_strategy.h View 1 chunk +9 lines, -3 lines 0 comments Download
M content/common/gpu/media/android_copying_backing_strategy.cc View 1 5 chunks +27 lines, -6 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.h View 3 chunks +6 lines, -7 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 5 chunks +3 lines, -28 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator_state_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
liberato (no reviews please)
small refactoring to keep the zero copy CL smaller. the zero copy backing strategy wants ...
5 years, 2 months ago (2015-09-25 18:46:49 UTC) #2
watk
lgtm https://codereview.chromium.org/1370443007/diff/1/content/common/gpu/media/android_copying_backing_strategy.h File content/common/gpu/media/android_copying_backing_strategy.h (right): https://codereview.chromium.org/1370443007/diff/1/content/common/gpu/media/android_copying_backing_strategy.h#newcode48 content/common/gpu/media/android_copying_backing_strategy.h:48: // A container of texture. Used to set ...
5 years, 2 months ago (2015-09-25 21:31:17 UTC) #3
liberato (no reviews please)
still need an owner lg*m for this one. thanks -fl
5 years, 2 months ago (2015-09-30 18:17:30 UTC) #4
sandersd (OOO until July 31)
lgtm
5 years, 2 months ago (2015-09-30 21:10:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370443007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370443007/40001
5 years, 2 months ago (2015-10-06 17:17:38 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-06 18:35:03 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 18:35:47 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f8c4d4c1b6b5bad95caaa836acc004be7b587a27
Cr-Commit-Position: refs/heads/master@{#352649}

Powered by Google App Engine
This is Rietveld 408576698