chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 137043005: Fix chrome.downloads.getFileIcon for hi-dpi and clarify docs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 137043005: Fix chrome.downloads.getFileIcon for hi-dpi and clarify docs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix hi-dpi Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/downloads/downloads_api.cc ('K') | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/common/extensions/api/downloads.idl » ('j') | chrome/common/extensions/api/downloads.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index 160681aaa67d9acf62bfaa11debd331ca0f70227..e86910b65b022a04c1710bbd19c00466ab2077f5 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -623,6 +623,7 @@ class MockIconExtractorImpl : public DownloadFileIconExtractor {

virtual ~MockIconExtractorImpl() {}

virtual bool ExtractIconURLForPath(const base::FilePath& path,

+ float scale,

IconLoader::IconSize icon_size,

IconURLCallback callback) OVERRIDE {

EXPECT_STREQ(expected_path_.value().c_str(), path.value().c_str());