Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: chrome/common/extensions/api/downloads.idl

Issue 137043005: Fix chrome.downloads.getFileIcon for hi-dpi and clarify docs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix hi-dpi Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Use the <code>chrome.downloads</code> API to programmatically initiate, 5 // Use the <code>chrome.downloads</code> API to programmatically initiate,
6 // monitor, manipulate, and search for downloads. 6 // monitor, manipulate, and search for downloads.
7 [permissions=downloads] 7 [permissions=downloads]
8 namespace downloads { 8 namespace downloads {
9 [inline_doc] dictionary HeaderNameValuePair { 9 [inline_doc] dictionary HeaderNameValuePair {
10 // Name of the HTTP header. 10 // Name of the HTTP header.
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 373
374 // The change in <code>fileSize</code>, if any. 374 // The change in <code>fileSize</code>, if any.
375 DoubleDelta? fileSize; 375 DoubleDelta? fileSize;
376 376
377 // The change in <code>exists</code>, if any. 377 // The change in <code>exists</code>, if any.
378 BooleanDelta? exists; 378 BooleanDelta? exists;
379 }; 379 };
380 380
381 [inline_doc] dictionary GetFileIconOptions { 381 [inline_doc] dictionary GetFileIconOptions {
382 // The size of the icon. The returned icon will be square with dimensions 382 // The size of the icon. The returned icon will be square with dimensions
383 // size * size pixels. The default size for the icon is 32x32 pixels. 383 // size * size pixels. The default and largest size for the icon is 32x32
384 // pixels. Valid values are 16 and 32. No other sizes are supported.
not at google - send to devlin 2014/01/14 19:16:24 just "The only supported sizes are 16 and 32, anyt
benjhayden 2014/01/15 23:58:20 Done.
384 [legalValues=(16,32)] long? size; 385 [legalValues=(16,32)] long? size;
385 }; 386 };
386 387
387 callback DownloadCallback = void(long downloadId); 388 callback DownloadCallback = void(long downloadId);
388 callback SearchCallback = void(DownloadItem[] results); 389 callback SearchCallback = void(DownloadItem[] results);
389 callback EraseCallback = void(long[] erasedIds); 390 callback EraseCallback = void(long[] erasedIds);
390 callback NullCallback = void(); 391 callback NullCallback = void();
391 callback GetFileIconCallback = void(optional DOMString iconURL); 392 callback GetFileIconCallback = void(optional DOMString iconURL);
392 callback SuggestFilenameCallback = void( 393 callback SuggestFilenameCallback = void(
393 optional FilenameSuggestion suggestion); 394 optional FilenameSuggestion suggestion);
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 // <code>suggestion</code> object to <code>suggest</code> wins. In order to 537 // <code>suggestion</code> object to <code>suggest</code> wins. In order to
537 // avoid confusion regarding which extension will win, users should not 538 // avoid confusion regarding which extension will win, users should not
538 // install extensions that may conflict. If the download is initiated by 539 // install extensions that may conflict. If the download is initiated by
539 // $ref:download and the target filename is known before the MIME type and 540 // $ref:download and the target filename is known before the MIME type and
540 // tentative filename have been determined, pass <code>filename</code> to 541 // tentative filename have been determined, pass <code>filename</code> to
541 // $ref:download instead. 542 // $ref:download instead.
542 [maxListeners=1] static void onDeterminingFilename( 543 [maxListeners=1] static void onDeterminingFilename(
543 DownloadItem downloadItem, SuggestFilenameCallback suggest); 544 DownloadItem downloadItem, SuggestFilenameCallback suggest);
544 }; 545 };
545 }; 546 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698