Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1370373004: Revert of DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8 (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
haraken, dgozman, pfeldman, yurys
CC:
chromium-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8 (patchset #5 id:80001 of https://codereview.chromium.org/1367623006/ ) Reason for revert: Broke oilpan: In file included from gen/blink/core/InspectorInstrumentationImpl.cpp:10: ../../third_party/WebKit/Source/core/inspector/AsyncCallTracker.h:58:5: error: only virtual member functions can be marked 'override' WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(AsyncCallTracker); ^ ../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:210:53: note: expanded from macro 'WILL_BE_USING_GARBAGE_COLLECTED_MIXIN' #define WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(TYPE) USING_GARBAGE_COLLECTED_MIXIN(TYPE) ^ ../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:199:5: note: expanded from macro 'USING_GARBAGE_COLLECTED_MIXIN' DEFINE_GARBAGE_COLLECTED_MIXIN_METHODS(blink::Visitor*, TYPE) \ ^ ../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:134:47: note: expanded from macro 'DEFINE_GARBAGE_COLLECTED_MIXIN_METHODS' void adjustAndMark(VISITOR visitor) const override Original issue's description: > DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8 > > V8DebuggerAgent was split into interface and implementation. All other agents should depend on the public part only. > > Once InjectedScript, InjectedScriptHost and InjectedScriptManager are also moved to .../inspector/v8 some of the methods on V8DebuggerAgent will be removed and called only by the implementation classes. > > BUG=439376 > > Committed: https://crrev.com/80862359ba867d2807e9ba7b366b352ee5cfda2b > Cr-Commit-Position: refs/heads/master@{#351166} TBR=dgozman@chromium.org,pfeldman@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=439376 Committed: https://crrev.com/3ef449bafc04114479f0e6a17ffdbc9fe7419b27 Cr-Commit-Position: refs/heads/master@{#351228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2206 lines, -2298 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncCallTracker.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncCallTracker.cpp View 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncOperationMap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 5 chunks +1 line, -14 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.cpp View 1 chunk +143 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/V8DebuggerAgent.h View 1 chunk +276 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/V8DebuggerAgent.cpp View 1 chunk +1702 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.h View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.cpp View 1 chunk +0 lines, -138 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h View 1 chunk +0 lines, -248 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 chunk +0 lines, -1695 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
Lei Zhang
Created Revert of DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8
5 years, 2 months ago (2015-09-29 01:42:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370373004/1
5 years, 2 months ago (2015-09-29 01:43:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 01:45:45 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3ef449bafc04114479f0e6a17ffdbc9fe7419b27 Cr-Commit-Position: refs/heads/master@{#351228}
5 years, 2 months ago (2015-09-29 01:46:33 UTC) #4
yurys
Do we now consider Oilpan breakage as a valid reason for reverting patches? I thought ...
5 years, 2 months ago (2015-09-29 02:00:54 UTC) #5
Lei Zhang
On 2015/09/29 02:00:54, yurys wrote: > Do we now consider Oilpan breakage as a valid ...
5 years, 2 months ago (2015-09-29 02:29:47 UTC) #6
Lei Zhang
+haraken ^^^ Whoever moved the oilpan bots to the main waterfall should have enabled oilpan ...
5 years, 2 months ago (2015-09-29 02:31:03 UTC) #8
haraken
On 2015/09/29 02:31:03, Lei Zhang wrote: > +haraken ^^^ > > Whoever moved the oilpan ...
5 years, 2 months ago (2015-09-29 02:46:57 UTC) #9
Lei Zhang
On 2015/09/29 02:46:57, haraken wrote: > On 2015/09/29 02:31:03, Lei Zhang wrote: > > +haraken ...
5 years, 2 months ago (2015-09-29 03:04:45 UTC) #10
yurys
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1374863002/ by yurys@chromium.org. ...
5 years, 2 months ago (2015-09-29 08:26:19 UTC) #11
sof
On 2015/09/29 08:26:19, yurys wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 2 months ago (2015-09-29 11:11:40 UTC) #12
yurys
5 years, 2 months ago (2015-09-29 18:56:18 UTC) #13
Message was sent while issue was closed.
On 2015/09/29 11:11:40, sof wrote:
> On 2015/09/29 08:26:19, yurys wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1374863002/ by mailto:yurys@chromium.org.
> > 
> > The reason for reverting is: The patch did not break main bots and should
not
> be
> > reverted..
> 
> Sure would have appreciated a heads-up before this reland, as it needlessly
> broke Oilpan again.

Sorry about that. We should probably start moving this code off Oilpan heap to
avoid such breakages.

Powered by Google App Engine
This is Rietveld 408576698