|
|
DescriptionFix another gcc 4.9.2 sign-compare error.
BUG=
Committed: https://crrev.com/88a3cc79df57dc4604c2e15605e1240473f261e7
Cr-Commit-Position: refs/heads/master@{#31063}
Patch Set 1 #
Messages
Total messages: 18 (7 generated)
The CQ bit was checked by paul.lind@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370353003/1
paul.lind@imgtec.com changed reviewers: + jkummerow@chromium.org, oth@chromium.org, rmcilroy@chromium.org
PTAL. I looked at changing the return type of Bytecodes::NumberOfOperands() to unsigned, but that will cause even more of these sign-difference DCHECK issues (in other places).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compil...)
paul.lind@imgtec.com changed reviewers: + machenbach@google.com
Michael, could you please look at the 2 failed try jobs? They appear to be infrastructure issues in applying the patch.
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370353003/1
On 2015/10/01 22:11:13, paul.l... wrote: > Michael, could you please look at the 2 failed try jobs? They appear to be > infrastructure issues in applying the patch. Looks like those were both due to network failures. In that case lets just try again...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Lgtm. Apologies, looks like I lost your previous fix in rebasing. Thanks!
The CQ bit was checked by rmcilroy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370353003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/88a3cc79df57dc4604c2e15605e1240473f261e7 Cr-Commit-Position: refs/heads/master@{#31063} |