Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 1370353003: Fix another gcc 4.9.2 sign-compare error. (Closed)

Created:
5 years, 2 months ago by paul.l...
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix another gcc 4.9.2 sign-compare error. BUG= Committed: https://crrev.com/88a3cc79df57dc4604c2e15605e1240473f261e7 Cr-Commit-Position: refs/heads/master@{#31063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/interpreter/bytecode-array-builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370353003/1
5 years, 2 months ago (2015-10-01 20:45:58 UTC) #2
paul.l...
PTAL. I looked at changing the return type of Bytecodes::NumberOfOperands() to unsigned, but that will ...
5 years, 2 months ago (2015-10-01 20:50:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/5368)
5 years, 2 months ago (2015-10-01 20:51:48 UTC) #6
paul.l...
Michael, could you please look at the 2 failed try jobs? They appear to be ...
5 years, 2 months ago (2015-10-01 22:11:13 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370353003/1
5 years, 2 months ago (2015-10-02 06:41:14 UTC) #10
Michael Achenbach
On 2015/10/01 22:11:13, paul.l... wrote: > Michael, could you please look at the 2 failed ...
5 years, 2 months ago (2015-10-02 06:41:48 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-02 06:46:47 UTC) #13
rmcilroy
Lgtm. Apologies, looks like I lost your previous fix in rebasing. Thanks!
5 years, 2 months ago (2015-10-02 06:57:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370353003/1
5 years, 2 months ago (2015-10-02 06:57:59 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 06:59:50 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 07:00:08 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88a3cc79df57dc4604c2e15605e1240473f261e7
Cr-Commit-Position: refs/heads/master@{#31063}

Powered by Google App Engine
This is Rietveld 408576698