Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1370343002: Revert of scheduler: Add a base directory (Closed)

Created:
5 years, 2 months ago by pavely
Modified:
5 years, 2 months ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, scheduler-bugs_chromium.org, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of scheduler: Add a base directory (patchset #4 id:60001 of https://codereview.chromium.org/1374653003/ ) Reason for revert: Change causes compile failure: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/6135 Original issue's description: > scheduler: Add a base directory > > This patch moves the more fundamental scheduling primitives (e.g., > TaskQueueManager) to a separate base/ directory. This makes the layered > architecture of the scheduler more obvious and reduces the likelihood of > accidentally introducing layering violations. > > With this refactoring, the overall dependencies are: > > +------+ > | base | > +------+ > ^ > | > +-------+ +------+ > | child |<----| test | > +-------+ +------+ > ^ ^ ^ ^ > | | | | > | '----------|-|---. > | .----------' '-. | > | | | | > +----------+ +-------+ > | renderer | | ppapi | > +----------+ +-------+ > > Committed: https://crrev.com/516bee16e9437521cdd20a78d683f9dbaf35df3e > Cr-Commit-Position: refs/heads/master@{#351109} TBR=jochen@chromium.org,alexclarke@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8416901cc7796ee6892942bcda40b83f0e5a1bb4 Cr-Commit-Position: refs/heads/master@{#351171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4456 lines, -4476 lines) Patch
M components/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 3 chunks +10 lines, -12 lines 0 comments Download
M components/scheduler/BUILD.gn View 2 chunks +9 lines, -9 lines 0 comments Download
D components/scheduler/base/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D components/scheduler/base/cancelable_closure_holder.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/scheduler/base/cancelable_closure_holder.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D components/scheduler/base/lazy_now.h View 1 chunk +0 lines, -37 lines 0 comments Download
D components/scheduler/base/lazy_now.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D components/scheduler/base/nestable_single_thread_task_runner.h View 1 chunk +0 lines, -32 lines 0 comments Download
D components/scheduler/base/nestable_task_runner_for_test.h View 1 chunk +0 lines, -40 lines 0 comments Download
D components/scheduler/base/nestable_task_runner_for_test.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D components/scheduler/base/pollable_thread_safe_flag.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/scheduler/base/pollable_thread_safe_flag.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D components/scheduler/base/task_queue.h View 1 chunk +0 lines, -184 lines 0 comments Download
D components/scheduler/base/task_queue.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D components/scheduler/base/task_queue_impl.h View 1 chunk +0 lines, -212 lines 0 comments Download
D components/scheduler/base/task_queue_impl.cc View 1 chunk +0 lines, -504 lines 0 comments Download
D components/scheduler/base/task_queue_manager.h View 1 chunk +0 lines, -261 lines 0 comments Download
D components/scheduler/base/task_queue_manager.cc View 1 chunk +0 lines, -464 lines 0 comments Download
D components/scheduler/base/task_queue_manager_perftest.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D components/scheduler/base/task_queue_manager_unittest.cc View 1 chunk +0 lines, -1309 lines 0 comments Download
D components/scheduler/base/task_queue_selector.h View 1 chunk +0 lines, -100 lines 0 comments Download
D components/scheduler/base/task_queue_selector.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D components/scheduler/base/task_queue_selector_unittest.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D components/scheduler/base/task_queue_sets.h View 1 chunk +0 lines, -75 lines 0 comments Download
D components/scheduler/base/task_queue_sets.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D components/scheduler/base/task_queue_sets_unittest.cc View 1 chunk +0 lines, -239 lines 0 comments Download
D components/scheduler/base/test_always_fail_time_source.h View 1 chunk +0 lines, -25 lines 0 comments Download
D components/scheduler/base/test_always_fail_time_source.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D components/scheduler/base/test_time_source.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/scheduler/base/test_time_source.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M components/scheduler/child/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A components/scheduler/child/cancelable_closure_holder.h View 1 chunk +39 lines, -0 lines 0 comments Download
A components/scheduler/child/cancelable_closure_holder.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M components/scheduler/child/child_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/idle_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/idle_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/idle_helper_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A components/scheduler/child/lazy_now.h View 1 chunk +37 lines, -0 lines 0 comments Download
A components/scheduler/child/lazy_now.cc View 1 chunk +19 lines, -0 lines 0 comments Download
A components/scheduler/child/nestable_single_thread_task_runner.h View 1 chunk +32 lines, -0 lines 0 comments Download
A components/scheduler/child/nestable_task_runner_for_test.h View 1 chunk +42 lines, -0 lines 0 comments Download
A components/scheduler/child/nestable_task_runner_for_test.cc View 1 chunk +48 lines, -0 lines 0 comments Download
A components/scheduler/child/pollable_thread_safe_flag.h View 1 chunk +35 lines, -0 lines 0 comments Download
A components/scheduler/child/pollable_thread_safe_flag.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M components/scheduler/child/scheduler_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/scheduler_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/scheduler_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/scheduler_task_runner_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/scheduler_task_runner_delegate_for_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/scheduler/child/task_queue.h View 1 chunk +184 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_impl.h View 1 chunk +212 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_impl.cc View 1 chunk +504 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_manager.h View 1 chunk +261 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_manager.cc View 1 chunk +464 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_manager_perftest.cc View 1 chunk +141 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_manager_unittest.cc View 1 chunk +1294 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_selector.h View 1 chunk +100 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_selector.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_selector_unittest.cc View 1 chunk +283 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_sets.h View 1 chunk +75 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_sets.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A components/scheduler/child/task_queue_sets_unittest.cc View 1 chunk +239 lines, -0 lines 0 comments Download
A components/scheduler/child/test_time_source.h View 1 chunk +30 lines, -0 lines 0 comments Download
A components/scheduler/child/test_time_source.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/worker_scheduler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/worker_scheduler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/ppapi/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/ppapi/webthread_impl_for_ppapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/renderer/deadline_task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/renderer_web_scheduler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/task_cost_estimator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/scheduler.gypi View 2 chunks +16 lines, -16 lines 0 comments Download
M components/scheduler/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A components/scheduler/test/test_always_fail_time_source.h View 1 chunk +25 lines, -0 lines 0 comments Download
A components/scheduler/test/test_always_fail_time_source.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pavely
Created Revert of scheduler: Add a base directory
5 years, 2 months ago (2015-09-28 22:10:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370343002/1
5 years, 2 months ago (2015-09-28 22:13:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 22:17:00 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:17:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8416901cc7796ee6892942bcda40b83f0e5a1bb4
Cr-Commit-Position: refs/heads/master@{#351171}

Powered by Google App Engine
This is Rietveld 408576698