Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1370323005: Remove dependence on header file unistd.h. (Closed)

Created:
5 years, 2 months ago by Karl
Modified:
5 years, 2 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dependence on header file unistd.h. Fixes bug in function reportFatalErrorThenExitSuccess by using fwrite instead of write (a unix posix include file not supported by MSC). BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7e64eaaadcbd40c94deba3f03a571abfaa2fc086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M src/IceCompileServer.cpp View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Karl
5 years, 2 months ago (2015-10-02 16:53:29 UTC) #2
Jim Stichnoth
lgtm
5 years, 2 months ago (2015-10-02 16:54:29 UTC) #3
Karl
5 years, 2 months ago (2015-10-02 17:49:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e64eaaadcbd40c94deba3f03a571abfaa2fc086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698