Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: pkg/analyzer/lib/src/plugin/engine_plugin.dart

Issue 1370323003: Fix computation of errors to not run extra tasks (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.plugin.engine_plugin; 5 library analyzer.src.plugin.engine_plugin;
6 6
7 import 'package:analyzer/plugin/task.dart'; 7 import 'package:analyzer/plugin/task.dart';
8 import 'package:analyzer/src/generated/engine.dart' 8 import 'package:analyzer/src/generated/engine.dart'
9 show InternalAnalysisContext; 9 show InternalAnalysisContext;
10 import 'package:analyzer/src/generated/error.dart' show AnalysisError; 10 import 'package:analyzer/src/generated/error.dart' show AnalysisError;
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 void registerExtensions(RegisterExtension registerExtension) { 152 void registerExtensions(RegisterExtension registerExtension) {
153 _registerTaskExtensions(registerExtension); 153 _registerTaskExtensions(registerExtension);
154 _registerWorkManagerFactoryExtensions(registerExtension); 154 _registerWorkManagerFactoryExtensions(registerExtension);
155 _registerDartErrorsForSource(registerExtension); 155 _registerDartErrorsForSource(registerExtension);
156 _registerDartErrorsForUnit(registerExtension); 156 _registerDartErrorsForUnit(registerExtension);
157 _registerHtmlErrors(registerExtension); 157 _registerHtmlErrors(registerExtension);
158 } 158 }
159 159
160 void _registerDartErrorsForSource(RegisterExtension registerExtension) { 160 void _registerDartErrorsForSource(RegisterExtension registerExtension) {
161 String id = DART_ERRORS_FOR_SOURCE_EXTENSION_POINT_ID; 161 String id = DART_ERRORS_FOR_SOURCE_EXTENSION_POINT_ID;
162 registerExtension(id, BUILD_DIRECTIVES_ERRORS);
163 registerExtension(id, BUILD_LIBRARY_ERRORS);
164 registerExtension(id, PARSE_ERRORS); 162 registerExtension(id, PARSE_ERRORS);
165 registerExtension(id, SCAN_ERRORS); 163 registerExtension(id, SCAN_ERRORS);
166 } 164 }
167 165
168 void _registerDartErrorsForUnit(RegisterExtension registerExtension) { 166 void _registerDartErrorsForUnit(RegisterExtension registerExtension) {
169 String id = DART_ERRORS_FOR_UNIT_EXTENSION_POINT_ID; 167 String id = DART_ERRORS_FOR_UNIT_EXTENSION_POINT_ID;
170 registerExtension(id, LIBRARY_UNIT_ERRORS); 168 registerExtension(id, LIBRARY_UNIT_ERRORS);
171 } 169 }
172 170
173 void _registerHtmlErrors(RegisterExtension registerExtension) { 171 void _registerHtmlErrors(RegisterExtension registerExtension) {
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 * a [WorkManagerFactory]. 260 * a [WorkManagerFactory].
263 */ 261 */
264 void _validateWorkManagerFactoryExtension(Object extension) { 262 void _validateWorkManagerFactoryExtension(Object extension) {
265 if (extension is! WorkManagerFactory) { 263 if (extension is! WorkManagerFactory) {
266 String id = taskExtensionPoint.uniqueIdentifier; 264 String id = taskExtensionPoint.uniqueIdentifier;
267 throw new ExtensionError( 265 throw new ExtensionError(
268 'Extensions to $id must be a WorkManagerFactory'); 266 'Extensions to $id must be a WorkManagerFactory');
269 } 267 }
270 } 268 }
271 } 269 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | pkg/analyzer/lib/src/task/inputs.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698